invoice: Implement new plugin property USAGE_TRANSITIONS for usage plugins. #2082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age code. The intent is to be able to communicate these details to a (usage) plugin to provide more flexibility and possibly have the plugin aggregate usage points in a way that will be compatible with what Kill Bill usage module expects.
…ions to usage plugin.
We pass the exact list as seen by the usage Kill Bill module and keyed by {subscriptionId, unitType} (*)
(*) In practise, we could have multiple unit types so those are currently serialized (can be revisited).
* Allows to match IntelliJ indet settings (moreless * Allow to run/debug tests
When multiple catalog versions exist, we may have multiple usage intervals (ContiguousIntervalUsageInArrear) for the same subscription and usage section. Transitions need to be merged across those various intervals.
update oss parent pom.xml
4bcc00a to
c6f5a9e
Compare
c6f5a9e to
40c1b68
Compare
pierre
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent is to be able to communicate subscription transitions to a (usage) plugin to provide more flexibility and possibly have the plugin aggregate usage points in a way that will be compatible with what Kill Bill usage module expects. The new property is
USAGE_TRANSITIONS.In 7cea0bd, this is purely refactoring to be able to extract the computation of transitions from usage module from the usage item generation.
In [27570ae], this is the implementation to pass the new plugin property to usage plugins.
Tests: I verified the new property appears and is available from a usage plugin.