Skip to content

Create lua/middleclass.lua symlink to origin file#65

Closed
anuvyklack wants to merge 2 commits intokikito:masterfrom
anuvyklack:upstream-pull-request
Closed

Create lua/middleclass.lua symlink to origin file#65
anuvyklack wants to merge 2 commits intokikito:masterfrom
anuvyklack:upstream-pull-request

Conversation

@anuvyklack
Copy link
Copy Markdown

To make middleclass git repo work with Neovim plugin managers.

To make middleclass git repo work with Neovim plugin managers.
@Issafalcon
Copy link
Copy Markdown

This symlink approach unfortunately doesn't work on Windows OS. To prevent Noevim plugin authors from unintentionally breaking plugins on Windows, a different approach will be required to allow this repo to be used as a dependency in new Neovim plugins.

@wookayin
Copy link
Copy Markdown

wookayin commented Sep 20, 2022

In my opinion, windows users can just do git config --global core.symlinks true as a user-wide setting.

But why don't we move ROOT/middleclass.lua -> ROOT/lua/middleclass.lua if out-of-box support for windows users is a concern? (and put a symlink into ROOT). Actually I don't see any reason the file middleclass.lua must be placed on the root directory.

@anuvyklack
Copy link
Copy Markdown
Author

Everything ingenious is simple!

And create a symlink in the root to the lua/middleclass.lua file.
@Issafalcon
Copy link
Copy Markdown

Good solution! The git config update would have been fine, with some additional README updates, but this way is much better.

@alerque
Copy link
Copy Markdown

alerque commented Sep 23, 2022

Why still have the symlink at all? My experience is that will break more cases than it fixes. I would suggest just putting the file where it is usable by all relevant consumers in the first place and adjust usage to assume that location.

@kikito
Copy link
Copy Markdown
Owner

kikito commented Nov 3, 2025

Hi, I am a neovim user and I like neovim, but Lua usage is quite wide in a lot of other areas. The lua/ folder convention is not standardized enough across all of them. Other people expect files in src/ or script/. So I will not be adding this change. Thanks for taking the time to open a PR and apologies for not seeing it earlier; github notifications failed me.

@kikito kikito closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants