fix: don't rely on xcode compression #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's better to specify COMPRESS_PNG_FILES=YES in compiler flags. This is because Xcode compresses PNG images rather horribly; it tries to compress them in a way to make them better for rendering instead of size, but it's actually worse for rendering in practice since the extra time to read data on the NAND ends up being much more costly than what Xcode saves (which is just a few bitflips in the end...) In this commit, I have specified Xcode to not compress PNG images, and have ran them through a lossless compressor so they maintain the same quality while still being better for storage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's better to specify COMPRESS_PNG_FILES=YES in compiler flags. This is because Xcode compresses PNG images rather horribly; it tries to compress them in a way to make them better for rendering instead of size, but it's actually worse for rendering in practice since the extra time to read data on the NAND ends up being much more costly than what Xcode saves (which is just a few bitflips in the end...)
In this commit, I have specified Xcode to not compress PNG images, and have ran them through a lossless compressor so they maintain the same quality while still being better for storage.
If you have any suggestions or feedback on this PR let me know.