feat(ssl): added timeout option#5475
feat(ssl): added timeout option#5475soloio-bulldozer[bot] merged 1 commit intokgateway-dev:masterfrom
Conversation
d27dc4e to
7699185
Compare
|
Issues linked to changelog: |
sam-heilbron
left a comment
There was a problem hiding this comment.
Looks good! Small question and ask
| // If present and nonzero, the amount of time to allow incoming connections to complete any | ||
| // transport socket negotiations. If this expires before the transport reports connection | ||
| // establishment, the connection is summarily closed. | ||
| google.protobuf.Duration transport_socket_connect_timeout = 10; |
There was a problem hiding this comment.
If this field is 0, what is the default behavior?
There was a problem hiding this comment.
Default behavior appears to be this: https://github.com/envoyproxy/envoy/blob/d142c9d55ae9aab34e9924aa25f20bd27635e060/source/server/listener_manager_impl.cc#L949
618022d to
bb1d369
Compare
sam-heilbron
left a comment
There was a problem hiding this comment.
Small comment about the unit test, but the rest looks good!
passthrough functionality for "TLS handshake timeout". Envoy has supported this [for a bit](envoyproxy/envoy#13610), and this PR will allow gloo-edge to support the functionality as well. [Referenced Documentation Here](https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/listener/v3/listener_components.proto#config-listener-v3-filterchain) closes solo-io#5438
bb1d369 to
f0b24e2
Compare
elcasteel
left a comment
There was a problem hiding this comment.
LGTM!
FYI Github will squash commits before merging so you don't need to rebase and it's a little easier for reviewers to see the history of comments being addressed if you maintain the original commit history.
closes solo-io#5438
Description
Passthrough functionality for "TLS handshake timeout"--added new proto option to ssl.proto:
transport_socket_connect_timeoutContext
Envoy has supported this for a bit, and this PR will allow
gloo-edgeto support the functionality as well.Checklist:
make -B install-go-tools generated-codeto ensure there will be no code diffBOT NOTES:
resolves solo-io#5438