Disable rest eds#4028
Merged
soloio-bulldozer[bot] merged 7 commits intomasterfrom Dec 28, 2020
Merged
Conversation
|
Issues linked to changelog: |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disable REST EDS server by default, which is no longer necessary now that upstream envoy has fixed envoyproxy/envoy#13070
Context
REST EDS was a workaround to avoid the bug in envoy, but we now depend on envoy-gloo 1.17.0-rc3 which itself depends on envoy https://github.com/solo-io/envoy-gloo/blob/master/bazel/repository_locations.bzl#L4 from commit 6be36debaf627925ebf5e22e84e7e066191b14d5
Checklist:
make install-go-tools generated-codeto ensure there will be no code diffBOT NOTES:
resolves [Migrated] Enable rest XDS for endpoints to fix race condition in envoy solo-io/gloo#3805