Skip to content

Disable rest eds#4028

Merged
soloio-bulldozer[bot] merged 7 commits intomasterfrom
disable_rest_eds
Dec 28, 2020
Merged

Disable rest eds#4028
soloio-bulldozer[bot] merged 7 commits intomasterfrom
disable_rest_eds

Conversation

@kdorosh
Copy link
Copy Markdown
Contributor

@kdorosh kdorosh commented Dec 28, 2020

Description

Disable REST EDS server by default, which is no longer necessary now that upstream envoy has fixed envoyproxy/envoy#13070

Context

REST EDS was a workaround to avoid the bug in envoy, but we now depend on envoy-gloo 1.17.0-rc3 which itself depends on envoy https://github.com/solo-io/envoy-gloo/blob/master/bazel/repository_locations.bzl#L4 from commit 6be36debaf627925ebf5e22e84e7e066191b14d5

Checklist:

@solo-changelog-bot
Copy link
Copy Markdown

Issues linked to changelog:
solo-io#3805

@kdorosh kdorosh removed the request for review from EItanya December 28, 2020 15:45
Copy link
Copy Markdown
Contributor

@Sodman Sodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@soloio-bulldozer soloio-bulldozer Bot merged commit d313a43 into master Dec 28, 2020
@soloio-bulldozer soloio-bulldozer Bot deleted the disable_rest_eds branch December 28, 2020 16:05
@ashleywang1 ashleywang1 mentioned this pull request Jan 21, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable rest XDS for endpoints to fix race condition in envoy Transient 503 UH "no healthy upstream" errors during CDS updates

2 participants