Critical fix to properly create and delete volumes#2
Merged
Conversation
kfox1111
reviewed
Mar 22, 2019
kfox1111
left a comment
Owner
There was a problem hiding this comment.
Looks good to me. Only the tiniest of issues inline.
| volName := fmt.Sprintf("ephemeral-%s", volID) | ||
| vol, err := createHospathVolume(req.GetVolumeId(), volName, maxStorageCapacity, mountAccess) | ||
| if err != nil && !os.IsExist(err) { | ||
| glog.Error("ephemeral mode failed to creatae volume: ", err) |
- Fix path references in ControllerServer - Refactor volume creation and deletion into createHostpathVolume()/deleteHospathVolume() functions - Update Node and Controller servers to use volume creation functions
218454e to
d9c5039
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createHostpathVolume()/deleteHospathVolume()functions