feat(web): configurable key-cap hints 🐵#9829
Merged
jahorton merged 12 commits intofeature-gesturesfrom Nov 6, 2023
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required |
10a57ac to
5eddecd
Compare
mcdurdin
approved these changes
Oct 24, 2023
jahorton
commented
Oct 31, 2023
Base automatically changed from
fix/web/state-change-source-rewrite
to
feature-gestures
November 6, 2023 01:27
Co-authored-by: Marc Durdin <marc@durdin.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5079.
Fully integrates the new 'hint' property supported for touch layouts within KeymanWeb.
Note that a few styling differences were necessary to accomplish this...
:beforepseudo-element. Kinda necessary, since the hint is no longer statically defined.\u2022dot is used.Some example screenshots from some test-oriented keyboards I'm developing:
(defaultHint: 'flick')
(each key has a custom
hintvalue)And, of course, we mustn't break the classic:
(a pre-existing keyboard defining neither
hintnordefaultHint)@keymanapp-test-bot skip