Merged
Conversation
Fixes #9720. Note: this will deprecate a number of Keyman Core APIs -- pretty much all existing action and context APIs. Deprecation marks will come in a follow-up commit.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
commented
Oct 23, 2023
sgschantz
reviewed
Oct 23, 2023
Contributor
sgschantz
left a comment
There was a problem hiding this comment.
It will be a nice improvement, but I have a few comments on naming and documentation of the APIs.
srl295
reviewed
Oct 23, 2023
srl295
reviewed
Oct 23, 2023
srl295
reviewed
Oct 23, 2023
Member
Author
|
Note: failed build due to #9832. |
Fixes #9832. Addresses a couple of other cross-platform compile issues.
* Renamed various functions and types * Clarified return values * Updated doc comments
sgschantz
approved these changes
Oct 24, 2023
Contributor
sgschantz
left a comment
There was a problem hiding this comment.
thanks for making these changes -- I will be calling this code very soon!
ermshiperete
requested changes
Oct 24, 2023
ermshiperete
requested changes
Oct 24, 2023
ermshiperete
approved these changes
Oct 25, 2023
Contributor
ermshiperete
left a comment
There was a problem hiding this comment.
Thanks for the changes! I'm happy now 😄
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.198-alpha |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9720.
Fixes #9832.
Note: this should make a number of Keyman Core context and action APIs unnecessary, except for use by IMX and debugger. Once we move over to these APIs with existing Engines, then we should audit the remaining usage and remove unnecessary APIs to reduce the maintenance burden.
@keymanapp-test-bot skip