feat(web): subkey-menu fat-finger correction 🐵#9779
Merged
jahorton merged 7 commits intofeature-gesturesfrom Oct 24, 2023
Merged
feat(web): subkey-menu fat-finger correction 🐵#9779jahorton merged 7 commits intofeature-gesturesfrom
jahorton merged 7 commits intofeature-gesturesfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required |
jahorton
commented
Oct 17, 2023
jahorton
commented
Oct 18, 2023
Comment on lines
+316
to
+318
| const altKey = pair.keySpec; | ||
| if(!altKey) { | ||
| console.warn("Potential fat-finger key could not be found in layer!"); | ||
| console.warn("Internal error: failed to properly filter set of keys for corrections"); |
Contributor
Author
There was a problem hiding this comment.
This obviously is connected to this ongoing Sentry error: https://keyman.sentry.io/share/issue/977c8e43dc1b40ddb7f6948252a6118b/
Note that the new pattern directly uses the object that was previously retrieved by lookup. There will no longer be an inability to find the object.
Of course, that doesn't solve the whole problem - whatever had happened to the layer, and how whatever that is should be handled in relation to fat-fingering - but this should help us get closer to finding the root of the issue, even then.
… into feat/web/subkey-corrections
… into feat/web/subkey-corrections
mcdurdin
approved these changes
Oct 22, 2023
Base automatically changed from
refactor/web/corrective-layout-abstraction
to
feature-gestures
October 24, 2023 02:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4698.
Now that #9778 exists, we have a path forward to finally resolve an old hack:
keyman/web/src/engine/osk/src/visualKeyboard.ts
Lines 578 to 583 in af3ba1f
Subkey fat-finger corrections look simpler to handle / model than multitap corrections, so it seems wise to tackle them first in order to vet the sort of approach (and abstractions) that will be needed for multitaps and flicks down the line.
Furthermore, by fixing this now, we can finally sever the last tie held by
VisualKeyboardcode to the old-form spec used to distinguish between base key and subkey state. That, in turn, allows us to remove numerous references to old OSK code that is being replaced by the new gesture engine... once we also update the banner to use the gesture engine. Both the removal and the banner patch-up work will be performed in #9752.@keymanapp-test-bot skip