chore(windows): remove WM_UNICHAR completely#8744
Merged
rc-swag merged 4 commits intochore/windows/8681/remove-addinsfrom May 15, 2023
Merged
chore(windows): remove WM_UNICHAR completely#8744rc-swag merged 4 commits intochore/windows/8681/remove-addinsfrom
rc-swag merged 4 commits intochore/windows/8681/remove-addinsfrom
Conversation
User Test ResultsTest specification and instructions
Test Artifacts |
mcdurdin
reviewed
May 11, 2023
Member
mcdurdin
left a comment
There was a problem hiding this comment.
very quick comments from our paired review
Comment on lines
-221
to
-230
| (unsigned int) GetMessageExtraInfo()); | ||
| else if(msg->message >= WM_KEYDOWN && msg->message <= WM_UNICHAR) | ||
| wsprintf(ds, "DebugMessage(%x, %s, wParam: '%c' (U+%04X), lParam: %X) [message flags: %x time: %d extra: %x]", | ||
| PtrToInt(msg->hwnd), | ||
| msgnames[msg->message-WM_KEYDOWN], | ||
| msg->wParam, | ||
| msg->wParam, | ||
| (unsigned int) msg->lParam, | ||
| wParam, | ||
| (int) msg->time, |
Member
There was a problem hiding this comment.
leave this as is, don't delete
Member
There was a problem hiding this comment.
this code hasn't yet been restored
mcdurdin
requested changes
May 11, 2023
Comment on lines
-221
to
-230
| (unsigned int) GetMessageExtraInfo()); | ||
| else if(msg->message >= WM_KEYDOWN && msg->message <= WM_UNICHAR) | ||
| wsprintf(ds, "DebugMessage(%x, %s, wParam: '%c' (U+%04X), lParam: %X) [message flags: %x time: %d extra: %x]", | ||
| PtrToInt(msg->hwnd), | ||
| msgnames[msg->message-WM_KEYDOWN], | ||
| msg->wParam, | ||
| msg->wParam, | ||
| (unsigned int) msg->lParam, | ||
| wParam, | ||
| (int) msg->time, |
Member
There was a problem hiding this comment.
this code hasn't yet been restored
Test Results
..in NotePad ..in Firefox browser 
..in Notepad 
.. Firefox browser 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8677
For this PR we can just load two different keyman keyboards and test that characters are still being output
User Testing
TEST_TAMIL_OUTPUT
Install Tamil 99 keyboard
Wordif you have it otherwise, FirefoxTEST_KHMER_ANGKOR
Install Khmer Angkor keyboard
Wordif you have it otherwise, Firefox