fix(common): consolidate npm publishing#8587
Merged
Conversation
Fixes #8586. All npm publish actions in the repository are now run as part of the Developer release build, hosted at present by kmc, until we setup a higher-level build script to do it. Adds a 'pack' action which mirrors 'publish' for all npm packages. Removes unnecessary dev dependencies of models-templates and models-wordbreakers from kmc-model. Web Release build CI step has been updated to check for presence of .build-builder.
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
reviewed
Apr 12, 2023
| "configure" \ | ||
| "build" \ | ||
| "test" \ | ||
| "pack" \ |
Contributor
There was a problem hiding this comment.
Can we have a description of pack? ...mirrors 'publish' for all npm packages
Contributor
There was a problem hiding this comment.
Huh, and it usually comes second here, after publish... yeah, could definitely use some more clarity there on exactly what the distinction is.
Member
Author
There was a problem hiding this comment.
"build a local .tgz pack for testing" okay? See #8588, will fix up other refs shortly.
This was
linked to
issues
Apr 12, 2023
Base automatically changed from
fix/developer/8508-file-not-exist-message
to
master
April 13, 2023 08:08
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.87-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8586.
Fixes #7310.
Four fixes all centred around npm publish:
The Web Release build CI step has been updated to check for presence of .build-builder for models-types.
@keymanapp-test-bot skip