feat(developer): support build of .kmn from kmc 🙀#8302
Merged
mcdurdin merged 2 commits intofeature-ldmlfrom Feb 27, 2023
Merged
feat(developer): support build of .kmn from kmc 🙀#8302mcdurdin merged 2 commits intofeature-ldmlfrom
mcdurdin merged 2 commits intofeature-ldmlfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
darcywong00
reviewed
Feb 24, 2023
| return false; | ||
| } | ||
|
|
||
| console.log(child.stdout); |
Contributor
There was a problem hiding this comment.
Should kmcomp info and warnings also go to console?
Member
Author
There was a problem hiding this comment.
They do, see below where stderr is logged. We will improve error reporting in a future PR.
cebc094 to
f59d880
Compare
226d343 to
91c6cb9
Compare
Uses existing kmcomp.exe to build .kmn files. Requires kmc to be in a subfolder of the Keyman Developer binary folder.
f59d880 to
113918d
Compare
Base automatically changed from
feat/developer/5283-kmc-command-line-refactor
to
feature-ldml
February 27, 2023 08:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses existing kmcomp.exe to build .kmn files. Requires kmc to be in a subfolder of the Keyman Developer binary folder.
@keymanapp-test-bot skip