refactor(android/engine): Split KMInAppKeyboardWebViewClient to new class 🛋#7983
Merged
darcywong00 merged 4 commits intomasterfrom Feb 1, 2023
Merged
refactor(android/engine): Split KMInAppKeyboardWebViewClient to new class 🛋#7983darcywong00 merged 4 commits intomasterfrom
darcywong00 merged 4 commits intomasterfrom
Conversation
* Add getters and setters for context and keyboardLoaded
User Test ResultsTest specification and instructions
Test Artifacts |
Test Results
|
darcywong00
commented
Jan 10, 2023
| KMLog.LogError(TAG, "pageLoaded and InAppKeyboard null"); | ||
| return; | ||
| } | ||
| KMManager.getKMKeyboard(keyboardType).keyboardSet = false; |
Contributor
Author
There was a problem hiding this comment.
I refactored a lot of these KMManager.getKMKeyboard() calls in the follow-on #7993
…MKeyboardWebViewClient
mcdurdin
approved these changes
Jan 24, 2023
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.40-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starts to address #7881
This extracts
KMManager.KMInAppKeyboardWebViewClientto a separateKMKeyboardWebViewClientclass.A follow-on PR will refactor KMManager.KMSystemKeyboardWebViewClient to use this class too.
The first commit was moving the class to a separate file. Diffs can be seen in the remaining commits.
Some changes in KMManger:
KMManager.InAppKeyboardLoadedrefactored to useInAppKeyboardWebViewClient.getKeyboardLoaded()andInAppKeyboardWebViewClient.setKeyboardLoaded()User Testing
Setup - Load the PR build of Keyman for Android