chore(core): changes ldml tsconfig to es2020 🙀#7328
Merged
mcdurdin merged 2 commits intofeature-ldmlfrom Sep 20, 2022
Merged
Conversation
Also splits the root tsconfig.json into tsconfig.cjs.json and tsconfig.esm.json. These are not typically used at present but in theory you could do a `tsc -b <tsconfig.x.json>` and build all modules. In practice, we still have some prebuild steps that make that a bit of a pain.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
Base automatically changed from
chore/developer/epic-ldml/7301-no-checksums-please-kmc
to
feature-ldml
September 19, 2022 23:31
Member
Author
|
note: jenkins build failure addressed in #7311. |
jahorton
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also splits the root tsconfig.json into tsconfig.cjs.json and tsconfig.esm.json. These are not typically used at present but in theory you could do a
tsc -b <tsconfig.x.json>and build all modules. In practice, we still have some prebuild steps that make that a bit of a pain.I have noted some inconsistency with
tsc -bwhen referenced modules have different module modes, so splitting them seems wise. Also helpful for a simple index of which modules are in which format...@keymanapp-test-bot skip