Conversation
|
It appears that this branch/PR contains 3-4 types of changes:
|
|
After a couple failed attempts to try to merge all the changes on master into this branch and resolve the conflicts, I'm going to punt for now. There are two possible ways forward, and it's not clear which one will be easier and less error prone:
|
|
Turns out that this will be quite useful for moving forward with #1045, so I took the time to figure out the merge. I've gotten it working for the most part, though in-app rotation isn't exactly in the best condition at times. Of course, that's exactly what #1045 seeks to address. (It does appear to cause significant in-app regression at present, while the system keyboard seems fine.) |
|
There are a few small parts of the in-app keyboard that need to be worked out in advance - sometimes swapping a keyboard in-app will cause the keyboard to completely disappear. (It can then be refreshed from selecting an alternate view, like the "info" or "getting started" views.) |
|
I think I'd like to see the disappearing keyboard in-app resolved before we go ahead with a merge of this. |
|
@mcdurdin Did you test it and see this still happen? I added code to help prevent that, and it's not been occurring since the last commit for me. |
|
@jahorton no -- I was going off your comment :) |
This PR arose from cleanup work. It is incomplete and from a branch that Gabe was working on. Needs to be reviewed as to whether or not we'll use it or dump it.