Skip to content

fix(ios): reset context when osk is resized#6428

Merged
mcdurdin merged 1 commit intobetafrom
fix/ios/6416-keyboard-switch-newContext
Mar 31, 2022
Merged

fix(ios): reset context when osk is resized#6428
mcdurdin merged 1 commit intobetafrom
fix/ios/6416-keyboard-switch-newContext

Conversation

@keyman-server
Copy link
Copy Markdown
Collaborator

@keyman-server keyman-server commented Mar 25, 2022 •
edited by mcdurdin
Loading

Fixes #6416.
Fixes #6112.

The OSK is being rebuilt when we change size in some cases, which causes the default layer to be incorrectly set.

User Testing

@keyman-server keyman-server added this to the B15S5 milestone Mar 25, 2022
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Mar 25, 2022
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Mar 25, 2022 •
edited
Loading

User Test Results

Test specification and instructions

  • ✅ TEST_DEFAULT_LAYER (PASSED): Tested this with updated iOS simulator along with Obolo_Chwerty#6351 (hence, I did not find the other Keyboard ( obolo_chwerty_3151) as mentioned by Marc. However, this PR is passed and it is working as expected. ie., while switching from some other other keyboard to obolo_chwerty keyboard, the default layer is set correctly (eg., in the shift layer). Seems to be working as expected. (notes)

Test Artifacts

@bharanidharanj
Copy link
Copy Markdown

bharanidharanj commented Mar 25, 2022

  • TEST_DEFAULT_LAYER (PASSED): Tested this with updated iOS simulator along with Obolo_Chwerty#6351 (hence, I did not find the other Keyboard ( obolo_chwerty_3151) as mentioned by Marc. However, this PR is passed and it is working as expected. ie., while switching from some other other keyboard to obolo_chwerty keyboard, the default layer is set correctly (eg., in the shift layer). Seems to be working as expected.

In-App Keyboard: (the default layer of the obolo_chwerty keyboard)

System Keyboard: (the default layer is in the shift layer)

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Mar 25, 2022
This was linked to issues Mar 30, 2022
bug(ios): switching keyboards does not trigger newContext #6416
Closed
bug(ios): in-app keyboard does not work correctly with start-of-sentence #6112
Closed
sgschantz
sgschantz approved these changes Mar 31, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@sgschantz sgschantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit c53edd9 into beta Mar 31, 2022
@mcdurdin mcdurdin deleted the fix/ios/6416-keyboard-switch-newContext branch March 31, 2022 20:32
@keyman-server
Copy link
Copy Markdown
Collaborator Author

keyman-server commented Apr 1, 2022

Changes in this pull request will be available for download in Keyman version 15.0.225-beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgschantz sgschantz sgschantz approved these changes

@mcdurdin mcdurdin Awaiting requested review from mcdurdin

Assignees

No one assigned

Labels

fix has-user-test ios/engine/ ios/

Projects

None yet

Milestone

B15S5

Development

Successfully merging this pull request may close these issues.

bug(ios): switching keyboards does not trigger newContext bug(ios): in-app keyboard does not work correctly with start-of-sentence

4 participants

@keyman-server @bharanidharanj @sgschantz @mcdurdin