chore(ios): project scripts should use /usr/bin/env bash#6114
Merged
keyman-server merged 1 commit intomasterfrom Jan 17, 2022
Merged
chore(ios): project scripts should use /usr/bin/env bash#6114keyman-server merged 1 commit intomasterfrom
keyman-server merged 1 commit intomasterfrom
Conversation
This was referenced Jan 17, 2022
Merged
darcywong00
reviewed
Jan 17, 2022
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellPath = "/usr/bin/env bash"; |
Contributor
There was a problem hiding this comment.
Do all shellPaths need to be updated?
Like ll. 1293 and 1306 (there may be more)
Collaborator
Author
|
Changes in this pull request will be available for download in Keyman version 15.0.179-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps building within XCode on M1 Mac.
Note that greadlink is not added to the path by default on M1 arch. So you also need to:
@keymanapp-test-bot skip