fix(web): call postKeystroke on banner touch 🕊#6004
Merged
Conversation
Relates to #3621. Ensures that the `begin postKeystroke` entry point is called when the user accepts a suggestion.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
13 tasks
rc-swag
reviewed
Dec 6, 2021
Contributor
rc-swag
left a comment
There was a problem hiding this comment.
just noticed a typo. I think Darcy is probably best to give the final tick of approval.
Co-authored-by: rc-swag <58423624+rc-swag@users.noreply.github.com>
Collaborator
|
Changes in this pull request will be available for download in Keyman version 15.0.179-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #3621.
Merges into #5963.
Ensures that the
begin postKeystrokeentry point is called when the user accepts a suggestion.@keymanapp-test-bot skip
We'll do testing separately later on this.