feat(windows): Keyman Core Integration - Support for IMX DLLs 🥑 #5936
feat(windows): Keyman Core Integration - Support for IMX DLLs 🥑 #5936
Conversation
User Test ResultsTest specification and instructions ✅ SUITE_SIMPLIFIED_CHINESE:
✅ SUITE_IMSAMPLE_KEYBOARD:
✅ SUITE_IMSAMPLE_KEYBOARD_IM_WINDOW:
Test Artifacts |
c154681 to
cfed6f1
Compare
76f8fc4 to
d8a6d5a
Compare
|
An outstanding issue is if an IM window is up waiting for a user code point selection and other keys are pressed on the keyboard those characters will be added to the context and output before the select character from the IMC window. This behaviour is the same as the current windows implementation. However, the core implementation the character entered is output 3 times. Looking at the logging I can see that |
User TestingNote there is another issue #6099 that fixes an issue for the IMX simplified Chinese keyboard where the enter key does not output to the app. So that is a known limitation in this PR. SUITE_SIMPLIFIED_CHINESE:This keyboard will display the IMX window as soon as a string the matches the pinyin for one or more characters are typed. Note: Enter does not work for this keyboard and will be addressed in issue #6099
SUITE_IMSAMPLE_KEYBOARD:imsample.zip <- @MakaraSok this is the latest here In this mode IM window is not shown rather the app text is updated with a menu when either
SUITE_IMSAMPLE_KEYBOARD_IM_WINDOW:This keyboard uses the letters Also in this location is two keys
|
|
I will look into this straight away. However, just noting test It is though in the third Suite |
Everything is copied from the "User Test Results" above. Nothing has been changed, except the results of the test and comments. Please double check the user test instructions provided. |
…okes-from-imx feat(windows): emit keystrokes for imx keydown/up actions 🥑
The windows engine shift modifier flag needs to only pass the K_MODIFIERFLAGS so do a bit wise and to clear the other flags
|
@rc-swag Please refer me to the latest keyboard package for testing this. Thanks. |
|
Also, please double check the test cases and ensure that there is no additional/duplicate cases in the sets/suites. Thanks. |
I tagged you in the test instructions were the Imsample.zip contains the latest keyboard. It was also in the conversation history but I removed it to avoid any confusion. I have been through the test instructions I renamed a duplicate name in the simplified Chinese backspace check. |
|
Changes in this pull request will be available for download in Keyman version 15.0.187-alpha |







Fixes #5650