Skip to content

feat(windows): manual keyboard caps tests#5808

Merged
rc-swag merged 4 commits intofeat/windows/keyman-caps-lock-storesfrom
feat/windows/manual-keyboard-caps-tests
Oct 8, 2021
Merged

feat(windows): manual keyboard caps tests#5808
rc-swag merged 4 commits intofeat/windows/keyman-caps-lock-storesfrom
feat/windows/manual-keyboard-caps-tests

Conversation

@rc-swag
Copy link
Copy Markdown
Contributor

@rc-swag rc-swag commented Oct 7, 2021

Add manual test layouts to assist in testing the Caps Lock behaviour based on the Caps Lock Stores. Also added a TestReadme.md with all the steps required for user and developer testing.

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link
Copy Markdown

User Test Results

User tests are not required

@mcdurdin mcdurdin changed the title Feat/windows/manual keyboard caps tests feat(windows): manual keyboard caps tests Oct 7, 2021
@mcdurdin
Copy link
Copy Markdown
Member

mcdurdin commented Oct 7, 2021

Can we add the full source folder for each keyboard as found on @ermshiperete's repo, rather than just the .kmn?

@rc-swag
Copy link
Copy Markdown
Contributor Author

rc-swag commented Oct 7, 2021

Can we add the full source folder for each keyboard as found on @ermshiperete's repo, rather than just the .kmn?

Sure we can. Like I said following the structure of what was done before there was just .kmn some had .kmx and some had the build folder as well.

@rc-swag
Copy link
Copy Markdown
Contributor Author

rc-swag commented Oct 7, 2021

@mcdurdin Do you want just the source folder or do you want the next level up also with the .kpj ?

@mcdurdin
Copy link
Copy Markdown
Member

mcdurdin commented Oct 7, 2021

@mcdurdin Do you want just the source folder or do you want the next level up also with the .kpj ?

The next level up with the .kpj as well -- everything except the build folder and .kpj.user file.

@rc-swag rc-swag force-pushed the feat/windows/manual-keyboard-caps-tests branch from 50eaec6 to 0590c9c Compare October 7, 2021 05:44
@github-actions github-actions bot added the feat label Oct 7, 2021
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for three things:

  1. please rename windows/src/test/manual-tests/caps_lock_stores to caps-lock-stores
  2. please rename windows/src/test/manual-tests/caps_lock_stores/capsAlwaysOff to caps_always_off (matches keyboard filename)
  3. We have also the caps_lock_headers folder in manual-tests? This seems to overlap significantly... we probably don't need both 😁

@rc-swag
Copy link
Copy Markdown
Contributor Author

rc-swag commented Oct 7, 2021

LGTM, except for three things:

  1. please rename windows/src/test/manual-tests/caps_lock_stores to caps-lock-stores
  2. please rename windows/src/test/manual-tests/caps_lock_stores/capsAlwaysOff to caps_always_off (matches keyboard filename)
  3. We have also the caps_lock_headers folder in manual-tests? This seems to overlap significantly... we probably don't need both 😁

Yes I saw the caps_lock_headers I looked at it and it doesn't seem to help test as many cases as the one Eberhard had created. I will remove it. It and the test_ was why I took a punt on underscores instead of hyphens :).
While I'm at these changes what do you think of renaming the capscontrol to shift_frees_caps and obviously updating all references in the TestReadme.md?

@mcdurdin
Copy link
Copy Markdown
Member

mcdurdin commented Oct 7, 2021

While I'm at these changes what do you think of renaming the capscontrol to shift_frees_caps and obviously updating all references in the TestReadme.md?

Sounds good to me.

@rc-swag rc-swag merged commit e4eeb03 into feat/windows/keyman-caps-lock-stores Oct 8, 2021
@rc-swag rc-swag deleted the feat/windows/manual-keyboard-caps-tests branch October 8, 2021 03:47
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 15.0.132-alpha

@rc-swag rc-swag self-assigned this Jun 2, 2023
@rc-swag rc-swag added this to the A15S15 milestone Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants