feat(windows): Keyman Core integration 🥑#5443
Merged
Conversation
Member
|
Note: I've added milestone A14S8, label windows/ (you need to have both windows/ and windows/engine/ for the category labels) |
905b7a1 to
364a17f
Compare
2dd6767 to
306546b
Compare
mcdurdin
requested changes
Jul 22, 2021
Member
mcdurdin
left a comment
There was a problem hiding this comment.
So far, so good 😉
Liking the set of changes here.
I have added a bunch of comments for a first round; I have avoided commenting on style as far as possible at this point but there's a bit of a mix of indents and brace styles which will need to be cleaned up.
Can you make sure you rollback files that are only whitespace changes? That helps to reduce the PR scope.
Looking forward to the next iteration!
windows/src/engine/keyman32/tests/keyman32-tests/keyman32-tests.vcxproj
Outdated
Show resolved
Hide resolved
rc-swag
commented
Jul 28, 2021
This functions was to update the keyboard options in the windows engine with the current options in the core However it is not needed as first thought. This is because the options will not be updated in first Non updatable call kmtip. This is due to the fact the actions will not be processed. A variation on the current core implementation. I am still pushing the branch as the unit test will be usefull.
Add save and restore methods for saving and restoring keyboard processor options.
mcdurdin
requested changes
Sep 20, 2021
Member
mcdurdin
left a comment
There was a problem hiding this comment.
This is getting close. Next step: user testing!
windows/src/engine/keyman32/tests/keyman-engine-tests/kmprocessactionstests.cpp
Outdated
Show resolved
Hide resolved
windows/src/engine/keyman32/tests/keyman-engine-tests/kmprocessactionstests.cpp
Outdated
Show resolved
Hide resolved
windows/src/engine/keyman32/tests/keyman-engine-tests/kmprocessactionstests.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Marc Durdin <marc@durdin.net>
Add test fixture to allow Setup and Teardown methods to be used for all km process action tests. Modified the DebugAssert macro to not do the early return on its own.
Co-authored-by: Marc Durdin <marc@durdin.net>
Contributor
Author
|
mcdurdin
approved these changes
Sep 22, 2021
…ws/preserving-keyboard-options-in-engine
…ard-options-in-engine feat(windows): preserving keyboard options in engine
SUITE_BASIC
SUITE_CONTEXT_TRACKING
|
Contributor
Author
Collaborator
|
Changes in this pull request will be available for download in Keyman version 15.0.122-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the common core keyman processor into the Keyman for Windows Engine.
Fixes #5011.