fix(mac): release window resources on close#4669
Merged
Conversation
Fixes #3972. Ensure that window controllers are released when we close the window, so that we are starting again when we want to use the window again in the future. There are a number of ugly patterns in this code, but fixing those is outside scope for the beta.
jahorton
approved these changes
Mar 15, 2021
Collaborator
|
Changes in this pull request will be available for download in Keyman version 14.0.260-beta |
Collaborator
|
Changes in this pull request will be available for download in Keyman version 15.0.20-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3972.
Ensure that window references are released when we close the window, so that we are starting again when we want to use the window again in the future.
There are a number of ugly patterns in this code, but fixing those is outside scope for the beta.