fix(ios): adds i18n for some error alerts#4577
fix(ios): adds i18n for some error alerts#4577jahorton merged 3 commits intofix/ios/2197-app-browser-pkg-downloadsfrom
Conversation
mcdurdin
left a comment
There was a problem hiding this comment.
LGTM, although I don't understand why the two Localizable.strings are both empty files?
There's... some sort of git setting necessary to override its defaults. Seems to think those plain-text files are actually binary for some reason. |
|
|
It thinks they are binary because they are UTF-16LE, which it doesn't recognise by default. |
|
@jahorton you'll also need to convert the existing strings files from UTF-16 to UTF-8. |
|
Took a bit to find it, but Xcode has this: It doesn't show unless you've clicked within the file, for some reason. The other caveat... is that it simply doesn't work. "Convert" did literally nothing (even when applied in the UTF-8 direction). Had to use an online tool instead. Yet another case of "thanks, Apple!" |
VSCode is my go-to for file encoding conversion, "Change file encoding" command |
|
While the files still aren't viewable on this PR, using "View File" no longer talks about the file being binary, so it should be fixed for the future now. |
|
Changes in this pull request will be available for download in Keyman version 14.0.253-beta |
|
Changes in this pull request will be available for download in Keyman version 15.0.19-alpha |

I identified a few escapees during work on #4568; time to round 'em up and let localization happen.
Note: is set as a child PR of #4568 due to high-proximity changes, along with one addition therein to highlight the need for this fix.