You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When reviewing this PR, it may be helpful to revisit #3718:
This PR standardizes the popup keys by not pre-pending the base key in the popup array.
When we stopped prepending the base key for phone-oriented form factors... we forgot to stop auto-selecting the first subkey. Before we disabled said prepending behavior, this had been intended to indicate that the base key was still selected... just as a subkey.
Of course, we still want to preserve this functionality if the keyboard specifies a subkey matching its base key. However...
This also fixes#3092 because now Keyboard creators can control if/where the base key appears in the popup keys.
So, we're given no guarantee for where the base key lies within the subkey array.
That said, there was an interesting feature that this enabled:
There are some cases where it may be appropriate to auto-select a subkey that doesn't match its base key. Due to the 'bug' left by #3718, this is behavior that's been in the 14.0 beta for a while, and it's pretty nifty for typing this language with a touch layout.
So, to preserve this 'nifty' behavior, I noticed and preserved a reasonable condition that developers could consider to deliberately allow this: the base key's ID matches that of the subkey, but the layer is different - the subkey highlighted above has layer = 'shift'. So, I turned it into a selection rule - if there's no perfectly-matching subkey, we'll take the first "near-match".
So, to preserve this 'nifty' behavior, I noticed and preserved a reasonable condition that developers could consider to deliberately allow this: the base key's ID matches that of the subkey, but the layer is different - the subkey highlighted above has layer = 'shift'. So, I turned it into a selection rule - if there's no perfectly-matching subkey, we'll take the first "near-match".
I like the concept but I am concerned that it adds unwarranted complexity to the touch layouts. This kind of 'accidental' feature is difficult to maintain over time and leads to complications, if we want to add more functionality to the OSK. I prefer these kinds of features to be deliberate -- e.g. having an isDefault property on the subkeys (which can be true only for one subkey in any given subkey array). That's more flexible in design and to accommodate. So, can you disable that functionality and we can revisit that in 15.0?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reviewing this PR, it may be helpful to revisit #3718:
When we stopped prepending the base key for phone-oriented form factors... we forgot to stop auto-selecting the first subkey. Before we disabled said prepending behavior, this had been intended to indicate that the base key was still selected... just as a subkey.
Of course, we still want to preserve this functionality if the keyboard specifies a subkey matching its base key. However...
Also from #3718:
So, we're given no guarantee for where the base key lies within the subkey array.
That said, there was an interesting feature that this enabled:
There are some cases where it may be appropriate to auto-select a subkey that doesn't match its base key. Due to the 'bug' left by #3718, this is behavior that's been in the 14.0 beta for a while, and it's pretty nifty for typing this language with a touch layout.
So, to preserve this 'nifty' behavior, I noticed and preserved a reasonable condition that developers could consider to deliberately allow this: the base key's ID matches that of the subkey, but the layer is different - the subkey highlighted above has
layer = 'shift'. So, I turned it into a selection rule - if there's no perfectly-matching subkey, we'll take the first "near-match".Interestingly, this fixes point 2 of #2990!