fix(mac): Modifier keys were resetting cached context#2588
Merged
Conversation
Fixes #2375. For applications that do not provide context to Keyman, Keyman was losing the context buffer whenever a modifier key was pressed or released. This change modifies the cache reset to occur only when the Command modifier is pressed.
This was
linked to
issues
Feb 11, 2020
Closed
This was
linked to
issues
Feb 11, 2020
jahorton
approved these changes
Feb 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2375.
For applications that do not provide context to Keyman, Keyman was losing the context buffer whenever a modifier key was pressed or released. This change modifies the cache reset to occur only when the Command modifier is pressed.
As a rider to this PR, local builds no longer require notarization if we disable the overzealous security configuration locally with
sudo spctl --master-disable. The build script check for the security status when doing a local deploy (use./build.sh -deploy quicklocal) so it should be reasonably robust.