Skip to content

[iOS] Fixes issues with context reset ops.#1764

Merged
jahorton merged 4 commits intoios-1212-context-bugfrom
ios-predictive-context-reset
May 14, 2019
Merged

[iOS] Fixes issues with context reset ops.#1764
jahorton merged 4 commits intoios-1212-context-bugfrom
ios-predictive-context-reset

Conversation

@jahorton
Copy link
Copy Markdown
Contributor

@jahorton jahorton commented May 8, 2019

Fixes the following issues:

  • [iOS] Choosing the in-app "Clear Text" option (or using other text-clearing operations) had the following bugs:
    • Did not reset KMW's tracked context, causing internal desyncs that can break predictive text
    • Failed to invalidate previous predictions and generate new ones.
      • Repro: type a fair bit of text, noting the available predictions when stopping. Clear text then click a prediction, and the results (before the fix) would effectively ignore that "Clear Text" was ever selected.

The latter fix has heavy merge conflicts with other pending work unless based upon #1756, since both this PR and that one affect very similar aspects of the codebase.

@jahorton jahorton added this to the P6S6 milestone May 8, 2019
@keyman-server
Copy link
Copy Markdown
Collaborator

OSK renders for Windows

@jahorton jahorton changed the base branch from ios-1212-context-bug to master May 8, 2019 07:28
@jahorton jahorton changed the base branch from master to ios-1212-context-bug May 8, 2019 07:28
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants