Skip to content

test(mac): add unit tests to validate first calls to compliance check#11724

Merged
sgschantz merged 5 commits intomasterfrom
fix/mac/11674-crash-during-compliance-check
Aug 26, 2024
Merged

test(mac): add unit tests to validate first calls to compliance check#11724
sgschantz merged 5 commits intomasterfrom
fix/mac/11674-crash-during-compliance-check

Conversation

@sgschantz
Copy link
Copy Markdown
Contributor

@sgschantz sgschantz commented Jun 6, 2024

This was intended to isolate and fix #11674, but these additional tests did not expose that issue. However, these tests are still useful for ensuring that the compliance object is safely created in different scenarios.

Also makes public the description method used for logging.

@keymanapp-test-bot skip

Also makes public the description method used for logging.
A private description method may have been an issue with
the older logging code.
To build successfully with Xcode, it was necessary to
change runOnlyForDeploymentPostprocessing=1. This was
apparently needed because of the upgrade to Xcode 15
@sgschantz sgschantz added this to the A18S3 milestone Jun 6, 2024
@sgschantz sgschantz self-assigned this Jun 6, 2024
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Jun 6, 2024

User Test Results

Test specification and instructions

User tests are not required

@github-actions github-actions bot added the fix label Jun 6, 2024
@mcdurdin mcdurdin modified the milestones: A18S3, A18S4 Jun 7, 2024
@darcywong00 darcywong00 modified the milestones: A18S4, A18S5 Jun 21, 2024
@darcywong00 darcywong00 modified the milestones: A18S5, A18S6 Jul 8, 2024
@darcywong00 darcywong00 modified the milestones: A18S6, A18S7 Jul 19, 2024
@darcywong00 darcywong00 modified the milestones: A18S7, A18S8 Aug 2, 2024
@darcywong00 darcywong00 modified the milestones: A18S8, A18S9 Aug 17, 2024
@sgschantz sgschantz marked this pull request as ready for review August 21, 2024 04:44
@sgschantz sgschantz requested a review from SabineSIL as a code owner August 21, 2024 04:45
@sgschantz sgschantz changed the title fix(mac): add unit tests to validate first calls to compliance check test(mac): add unit tests to validate first calls to compliance check Aug 21, 2024
@github-actions github-actions bot added the test Any acceptance test issue label Aug 26, 2024
@sgschantz sgschantz merged commit 633abe3 into master Aug 26, 2024
@sgschantz sgschantz deleted the fix/mac/11674-crash-during-compliance-check branch August 26, 2024 07:02
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.98-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix mac/ test Any acceptance test issue

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

bug(mac): crash during compliance check

4 participants