feat(core): add deleted_context to km_core_actions struct 🌱#10533
Merged
mcdurdin merged 2 commits intoepic/core/9999-normalizationfrom Jan 30, 2024
Merged
Conversation
Fixes #10530. Adds the deleted_context member to the km_core_actions struct, and associated unit tests. Simplifies integration by providing the consumer with all the data they need in order to execute the transform, specifically around number of delete operations required, without needing to query the target application context again. The number of delete operations will vary according to application compliance and selected encoding; for example a UTF-16 string may require 2 delete-backs for surrogate pairs in the text buffer for a compliant app, whereas there will be a single delete-back key event for a non-compliant app. The deleted_context member should also be used for debug assertions.
User Test ResultsTest specification and instructions User tests are not required |
deleted_context to km_core_actions structdeleted_context to km_core_actions struct 🌱
rc-swag
approved these changes
Jan 29, 2024
Contributor
rc-swag
left a comment
There was a problem hiding this comment.
lgtm
Just a suggestion about how the end of the context is described.
| // -1=unchanged, 0=off, 1=on | ||
| km_core_caps_state new_caps_lock_state; | ||
|
|
||
| // reference copy of actual UTF32 codepoints deleted from rhs of context |
Contributor
There was a problem hiding this comment.
I think in the past we avoided "rhs" in the past due to right-to-left orientation. I believe kmx_context refers to the caret.
reference copy of actual UTF32 codepoints deleted from the end of the context closest to the caret
Base automatically changed from
fix/developer/10501-ldml-debugger-surrogate-pairs
to
epic/core/9999-normalization
January 30, 2024 00:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10530.
Adds the
deleted_contextmember to thekm_core_actionsstruct, and associated unit tests. Simplifies integration by providing the consumer with all the data they need in order to execute the transform, specifically around number of delete operations required, without needing to query the target application context again. The number of delete operations will vary according to application compliance and selected encoding; for example a UTF-16 string may require 2 delete-backs for surrogate pairs in the text buffer for a compliant app, whereas there will be a single delete-back key event for a non-compliant app.The
deleted_contextmember should also be used for debug assertions.@keymanapp-test-bot skip