fix(developer): support surrogate pairs in ldml debugger 🌱#10532
Merged
mcdurdin merged 1 commit intoepic/core/9999-normalizationfrom Jan 30, 2024
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required |
darcywong00
reviewed
Jan 29, 2024
| function ContextItemsLengthUTF16(pc: pkm_core_context_item): Integer; | ||
| begin | ||
| Result := 0; | ||
| while pc._type <> KM_CORE_CT_END do |
Contributor
There was a problem hiding this comment.
Is it possible for context items to never contain KM_CORE_CT_END?
Member
Author
There was a problem hiding this comment.
No, that's contractual on the part of the Core API:
keyman/core/include/keyman/keyman_core_api_context.h
Lines 198 to 200 in 41cc2f4
darcywong00
reviewed
Jan 29, 2024
| SetLength(outText, length + 1); | ||
|
|
||
| ox := 0; | ||
| Result := ''; |
Contributor
There was a problem hiding this comment.
Should this initialize to something with Result.Length = 0? Could a loop enter the else block on the first pass and hit l.514?
Member
Author
There was a problem hiding this comment.
Result := '' means that Result.Length = 0; .Length is a calculated property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10501.
@keymanapp-test-bot skip