refactor(linux): Use `km_core_actions` struct instead of queue 🌱 by ermshiperete · Pull Request #10480 · keymanapp/keyman

ermshiperete · 2024-01-23T16:12:14Z

Implements #10353.

User Testing

Preparations

The tests can be be run on any Linux platforms (running with X11). Note that Firefox and Chromium have to be installed from .deb, the snap version won't work because it's missing the ibus patch.

Install Anki

Download Qt5 version of Anki

Run the following commands

sudo apt update
sudo apt install zstd
tar xaf Downloads/anki-2.*-linux-qt5.tar.zst
cd anki-2.*-linux-qt5
sudo ./install.sh
sudo apt install libxcb-xinerama0

When testing in Anki, select e.g. "Tools"/"Study Deck"

Install patched ibus by running these commands:
```
sudo add-apt-repository ppa:keymanapp/keyman-alpha
sudo apt upgrade
```
- afterwards running dpkg -l ibus should show a version number with sil in the version string, e.g. 1.5.28-3sil2~jammy
Install build artifacts of this PR
Reboot
Install the following keyboards in Keyman:

SUITE_WRITER: LibreOffice Writer

Open LibreOffice Writer.

Tests

TEST_WRITER_IPA: Switch to "IPA (SIL)" keyboard. Type n>. Verify that the result is "ŋ".
TEST_WRITER_KO: Switch to "Korean KORDA Jamo (SIL)" keyboard. Type han<space>geul<space>. Verify that the result is "한글".
TEST_WRITER_HI: Switch to "Vedic Sanskrit Devanagari Phonetic (ITRANS)" keyboard. Type shrI. Verify that the result is "श्री". (If the result looks wrong, select all text and change the font to "Siddhanta")
TEST_WRITER_KM: Switch to "Khmer Angkor" keyboard. Select "Khmer Mondulkiri" font. Type xEjmr. Verify that the output is "ខ្មែរ".
TEST_WRITER_KM_BS: With the output "ខ្មែរ" still being displayed, press Backspace key 5 times. Verify that after each keystroke a part of the string is removed and after the 5th backspace the entire word is deleted.

SUITE_GEDIT: gedit

Open gedit.

Tests

TEST_GEDIT_IPA: Switch to "IPA (SIL)" keyboard. Type n>. Verify that the result is "ŋ".
TEST_GEDIT_KO: Switch to "Korean KORDA Jamo (SIL)" keyboard. Type han<space>geul<space>. Verify that the result is "한글".
TEST_GEDIT_HI: Switch to "Vedic Sanskrit Devanagari Phonetic (ITRANS)" keyboard. Type shrI. Verify that the result is "श्री".
TEST_GEDIT_KM: Switch to "Khmer Angkor" keyboard. Type xEjmr. Verify that the output is "ខ្មែរ".
TEST_GEDIT_KM_BS: With the output "ខ្មែរ" still being displayed, press Backspace key 5 times. Verify that after each keystroke a part of the string is removed and after the 5th backspace the entire word is deleted.

SUITE_FIREFOX: Firefox

Open https://keyman.com/keyboards in Firefox.

NOTE: If the output looks wrong, copy the text from the browser and paste it into gedit and verify that it there.

Tests

TEST_FIREFOX_IPA: Switch to "IPA (SIL)" keyboard. Type n>. Verify that the result is "ŋ".
TEST_FIREFOX_KO: Switch to "Korean KORDA Jamo (SIL)" keyboard. Type han<space>geul<space>. Verify that the result is "한글".
TEST_FIREFOX_HI: Switch to "Vedic Sanskrit Devanagari Phonetic (ITRANS)" keyboard. Type shrI. Verify that the result is "श्री".
TEST_FIREFOX_KM: Switch to "Khmer Angkor" keyboard. Type xEjmr. Verify that the output is "ខ្មែរ".

NOTE: Backspace with Firefox won't work correctly because of #9971).

SUITE_CHROMIUM: Chrome/Chromium

Open https://keyman.com/keyboards in Chrome/Chromium browser.

NOTE: If the output looks wrong, copy the text from the browser and paste it into gedit and verify that it there.

Tests

TEST_CHROMIUM_IPA: Switch to "IPA (SIL)" keyboard. Type n>. Verify that the result is "ŋ".
TEST_CHROMIUM_KO: Switch to "Korean KORDA Jamo (SIL)" keyboard. Type han<space>geul<space>. Verify that the result is "한글".
TEST_CHROMIUM_HI: Switch to "Vedic Sanskrit Devanagari Phonetic (ITRANS)" keyboard. Type shrI. Verify that the result is "श्री".
TEST_CHROMIUM_KM: Switch to "Khmer Angkor" keyboard. Type xEjmr. Verify that the output is "ខ្មែរ".
TEST_CHROMIUM_KM_BS: With the output "ខ្មែរ" still being displayed, press Backspace key 5 times. Verify that after each keystroke a part of the string is removed and after the 5th backspace the entire word is deleted.

SUITE_TERMINAL: gnome-terminal

Open Terminal.

Tests

TEST_TERMINAL_IPA: Switch to "IPA (SIL)" keyboard. Type n>. Verify that the result is "ŋ".

NOTE: the other tests for gnome-terminal won't work because of #10481

SUITE_ANKI: Anki

Open Anki.

Tests

TEST_ANKI_IPA: Switch to "IPA (SIL)" keyboard. Type n>. Verify that the result is "ŋ".
TEST_ANKI_KO: Switch to "Korean KORDA Jamo (SIL)" keyboard. Type han<space>geul<space>. Verify that the result is "한글".
TEST_ANKI_HI: Switch to "Vedic Sanskrit Devanagari Phonetic (ITRANS)" keyboard. Type shrI. Verify that the result is "श्री" (If the result looks wrong, copy/paste it in text editor and verify there).
TEST_ANKI_KM: Switch to "Khmer Angkor" keyboard. Type xEjmr. Verify that the output is "ខ្មែរ".
TEST_ANKI_KM_BS: With the output "ខ្មែរ" still being displayed, press Backspace key 5 times. Verify that after each keystroke a part of the string is removed and after the 5th backspace the entire word is deleted.

SUITE_SEARCHBAR: Searchbar in gnome-shell

Press Windows key to open searchbar.

Tests

TEST_SEARCHBAR_IPA: Switch to "IPA (SIL)" keyboard. Type n>. Verify that the result is "ŋ".
TEST_SEARCHBAR_KO: Switch to "Korean KORDA Jamo (SIL)" keyboard. Type han<space>geul<space>. Verify that the result is "한글".
TEST_SEARCHBAR_HI: Switch to "Vedic Sanskrit Devanagari Phonetic (ITRANS)" keyboard. Type shrI. Verify that the result is "श्री".
TEST_SEARCHBAR_KM: Switch to "Khmer Angkor" keyboard. Type xEjmr. Verify that the output is "ខ្មែរ".
TEST_SEARCHBAR_KM_BS: With the output "ខ្មែរ" still being displayed, press Backspace key 5 times. Verify that after each keystroke a part of the string is removed and after the 5th backspace the entire word is deleted.

…ueue Implements #10353.

keymanapp-test-bot · 2024-01-23T16:12:19Z

User Test Results

Test specification and instructions

✅ SUITE_WRITER: LibreOffice Writer

5 tests in 1 groups PASSED

✅ TEST_WRITER_IPA (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2125.1+mantic1) on Ubuntu 23.10 Mantic Minotaur OS (vm) and here is my observation: 1. Installed the above mentioned languages (IPA (SIL), Korean KORDA Jamo, Khmer Angkor and Vedic Sanskrit Devanagari..) using Keyman Configuration dialog. 2. Opened LibreOffice Writer. 3. Verified that the result ŋ appeared on the document. (notes)
✅ TEST_WRITER_KO (PASSED): 1. Verified that the result appeared on the document.
✅ TEST_WRITER_HI (PASSED): 1. Verified that the result श्री appeared on the document.
✅ TEST_WRITER_KM (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the khmer_angkor keyboard. 2. Switched to khmer_angkor keyboard. 3. Opened the LibreOffice Writer document. 4. Typed "xEjmr>" letters. 5. Noticed that it showed the correct output.
✅ TEST_WRITER_KM_BS (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the khmer_angkor keyboard. 2. Switched to khmer_angkor keyboard. 3. Opened the LibreOffice Writer document. 4. Typed "xEjmr" letters. 5. It showed the correct output. 6. With the output "ខ្មែរ" still being displayed, pressed the Backspace key 5 times. Verified that after each keystroke a part of the string is removed and after the 5th backspace the entire word was deleted.

✅ SUITE_GEDIT: gedit

5 tests in 1 groups PASSED

✅ TEST_GEDIT_IPA (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the sil_ipa keyboard. 2. Switched to sil_ipa keyboard. 3. Opened the terminal window. 4. Typed "n>" letters. 5. Noticed that it showed the correct output. (notes)
✅ TEST_GEDIT_KO (PASSED): 1. Verified that it is showing the correct output on the document.
✅ TEST_GEDIT_HI (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the vedic_sanskrit keyboard. 2. Switched to vedic_sanskrit keyboard. 3. Opened the terminal window. 4. Typed "n>" letters. 5. Noticed that it showed the correct output.
✅ TEST_GEDIT_KM (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the khmer_angkor keyboard. 2. Switched to khmer_angkor keyboard. 3. Opened the terminal window. 4. Typed "n>" letters. 5. Noticed that it showed the correct output.
✅ TEST_GEDIT_KM_BS (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the khmer_angkor Keyboard. 2. Opened Text Editor. 3. Switched to khmer_angkor keyboard. 4. With the output "ខ្មែរ" still being displayed, pressed the Backspace key 5 times. Verified that after each keystroke a part of the string is removed and after the 5th backspace the entire word was deleted.

✅ SUITE_FIREFOX: Firefox

4 tests in 1 groups PASSED

✅ TEST_FIREFOX_IPA (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2125.1+mantic1) on Ubuntu 23.10 Mantic Minotaur OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the above-mentioned languages (IPA (SIL), Korean KORDA Jamo, Khmer Angkor and Vedic Sanskrit Devanagari..) using Keyman Configuration dialog. 2. Opened Mozilla Firefox browser. 3. Opened https://keyman.com/keyboards link. 4. Switched to sil_ipa keyboard. 5. Verified it shows the expected result. (notes)
✅ TEST_FIREFOX_KO (PASSED): 1. Verified that it is showing the correct output on the document. (notes)
✅ TEST_FIREFOX_HI (PASSED): 1. Verified that it is showing the correct output on the document. (notes)
✅ TEST_FIREFOX_KM (PASSED): 1. Verified that it is showing the correct output on the document. (notes)

✅ SUITE_CHROMIUM: Chrome/Chromium

5 tests in 1 groups PASSED

✅ TEST_CHROMIUM_IPA (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the sil_ipa Keyboard. 2. Opened Chromium browser. 3. Opened https://keyman.com/keyboards link. 4. Switched to sil_ipa keyboard. 5. Noticed that it is showing the correct output.
✅ TEST_CHROMIUM_KO (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the Korean_KORDA Keyboard. 2. Opened Chromium browser. 3. Opened https://keyman.com/keyboards link. 4. Switched to korean_korda keyboard. 5. Noticed that it is showing the correct output.
✅ TEST_CHROMIUM_HI (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the vedic_sanskrit Keyboard. 2. Opened Chromium browser. 3. Opened https://keyman.com/keyboards link. 4. Switched to vedic_sanskrit keyboard. 5. Noticed that it is showing the correct output.
✅ TEST_CHROMIUM_KM (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the khmer_angkor Keyboard. 2. Opened Chromium browser. 3. Opened https://keyman.com/keyboards link. 4. Switched to khmer_angkor keyboard. 5. Noticed that it is showing the correct output.
✅ TEST_CHROMIUM_KM_BS (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the khmer_angkor Keyboard. 2. Opened Chromium browser. 3. Opened https://keyman.com/keyboards link. 4. Switched to khmer_angkor keyboard. 5. With the output "ខ្មែរ" still being displayed, pressed the Backspace key 5 times. Verified that after each keystroke a part of the string is removed and after the 5th backspace the entire word was deleted.

🟩 SUITE_TERMINAL: gnome-terminal

🟩 TEST_TERMINAL_IPA (SKIPPED): ): Fails because of bug(linux): IPA (SIL) keyboards don't work properly in gnome-terminal #10536

✅ SUITE_ANKI: Anki

5 tests in 1 groups PASSED

✅ TEST_ANKI_IPA (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2125.1+mantic1) on Ubuntu 23.10 Mantic Minotaur OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the above mentioned languages (IPA (SIL), Korean KORDA Jamo, Khmer Angkor and Vedic Sanskrit Devanagari..) using Keyman Configuration dialog. 2. Installed Anki application. 3. Opened it. Clicked Tools / Study Deck option. 4. In Study Deck window, Clicked the Search bar. 5. Switched to sil_ipa keyboard. 6. Typed 'n>' keys showed the expected output. (notes)
✅ TEST_ANKI_KO (PASSED): Noticed that it is showing the correct output. (notes)
✅ TEST_ANKI_HI (PASSED): Noticed that it is showing the correct output. (notes)
✅ TEST_ANKI_KM (PASSED): Noticed that it is showing the correct output. (notes)
✅ TEST_ANKI_KM_BS (PASSED): 1. Pressing Backspace key 5 times, removed the entire khmer_angkor word.

✅ SUITE_SEARCHBAR: Searchbar in gnome-shell

5 tests in 1 groups PASSED

✅ TEST_SEARCHBAR_IPA (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the sil_ipa keyboard. 2. Switched to sil_ipa keyboard. 3. Opened the terminal window. 4. Typed "n>" letters. 5. Noticed that it showed the correct output. (notes)
✅ TEST_SEARCHBAR_KO (PASSED): Noticed that it is showing the correct output. (notes)
✅ TEST_SEARCHBAR_HI (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the vedic_sanskrit keyboard. 2. Switched to vedic_sanskrit keyboard. 3. Opened the terminal window. 4. Typed "shrI" letters. 5. Noticed that it showed the correct output. (notes)
✅ TEST_SEARCHBAR_KM (PASSED): Noticed that it is showing the correct output. (notes)
✅ TEST_SEARCHBAR_KM_BS (PASSED): 1. Pressing Backspace key 5 times, removed the entire khmer_angkor word.

Test Artifacts

Linux
- Keyman for Linux

darcywong00 · 2024-01-24T02:27:37Z

linux/ibus-keyman/src/engine.c

+    // If we have an old ibus version without prefilter support, or a client that does support
+    // surrounding text we already did everything that needs to be done including forwarding
+    // a keystroke. So we can return TRUE to stop processing of this event.
+      return TRUE;


Does this mean finish_process_actions() never returns FALSE now?

Suggested change

return TRUE;

return TRUE;

Does this mean finish_process_actions() never returns FALSE now?

yes. And this means the method doesn't have to return a bool. Changed. Thanks!

mcdurdin

LGTM. Cleaner. No marker shenanigans!

linux/ibus-keyman/src/engine.c

mcdurdin · 2024-01-24T05:48:41Z

linux/ibus-keyman/src/engine.c

+    // If we have an old ibus version without prefilter support, or a client that does support
+    // surrounding text we already did everything that needs to be done including forwarding
+    // a keystroke. So we can return TRUE to stop processing of this event.
+      return TRUE;


Suggested change

return TRUE;

return TRUE;

bharanidharanj · 2024-01-24T12:35:45Z

SUITE_WRITER: LibreOffice Writer

TEST_WRITER_IPA (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2125.1+mantic1) on Ubuntu 23.10 Mantic Minotaur OS (vm) and here is my observation: 1. Installed the above mentioned languages (IPA (SIL), Korean KORDA Jamo, Khmer Angkor and Vedic Sanskrit Devanagari..) using Keyman Configuration dialog. 2. Opened LibreOffice Writer. 3. Verified that the result ŋ appeared on the document.
TEST_WRITER_KO (PASSED): 1. Verified that the result appeared on the document.
TEST_WRITER_HI (PASSED): 1. Verified that the result श्री appeared on the document.
TEST_WRITER_KM (FAILED): 1. Noticed that it is showing the wrong output.
TEST_WRITER_KM_BS (FAILED): 1. Did not pass the test since the previous one failed.

bharanidharanj · 2024-01-24T13:16:27Z

Test Results

SUITE_GEDIT: gedit

TEST_GEDIT_IPA (FAILED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2125.1+mantic1) on Ubuntu 23.10 Mantic Minotaur OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the above-mentioned languages (IPA (SIL), Korean KORDA Jamo, Khmer Angkor, and Vedic Sanskrit Devanagari..) using Keyman Configuration dialog. 2. Opened Text Editor. 3. Noticed that it is showing the wrong output.
TEST_GEDIT_KO (PASSED): 1. Verified that it is showing the correct output on the document.
TEST_GEDIT_HI (FAILED): 1. Noticed that it is showing the wrong output on the document.
TEST_GEDIT_KM (FAILED): 1. Noticed that it is showing the wrong output.
TEST_GEDIT_KM_BS (FAILED): 1. Did not pass the test since the previous one failed.

bharanidharanj · 2024-01-24T13:26:45Z

Test Results

SUITE_FIREFOX: Firefox

TEST_FIREFOX_IPA (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2125.1+mantic1) on Ubuntu 23.10 Mantic Minotaur OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the above-mentioned languages (IPA (SIL), Korean KORDA Jamo, Khmer Angkor and Vedic Sanskrit Devanagari..) using Keyman Configuration dialog. 2. Opened Mozilla Firefox browser. 3. Opened https://keyman.com/keyboards link. 4. Switched to sil_ipa keyboard. 5. Verified it shows the expected result.
TEST_FIREFOX_KO (PASSED): 1. Verified that it is showing the correct output on the document.
TEST_FIREFOX_HI (PASSED): 1. Verified that it is showing the correct output on the document.
TEST_FIREFOX_KM (PASSED): 1. Verified that it is showing the correct output on the document.

bharanidharanj · 2024-01-24T13:39:41Z

Test Results

SUITE_CHROMIUM: Chromium

TEST_CHROMIUM_IPA (FAILED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2125.1+mantic1) on Ubuntu 23.10 Mantic Minotaur OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the above mentioned languages (IPA (SIL), Korean KORDA Jamo, Khmer Angkor and Vedic Sanskrit Devanagari..) using Keyman Configuration dialog. 2. Opened Chromium browser. 3. Opened https://keyman.com/keyboards link. 4. Switched to sil_ipa keyboard. 5. Noticed that it is showing the wrong output. FYI, I have installed Mozilla Firefox and Chrome browsers from .deb.
TEST_CHROMIUM_KO (FAILED): 1. Noticed that it is showing the wrong output.
TEST_CHROMIUM_HI (FAILED): 1. Noticed that it is showing the wrong output.
TEST_CHROMIUM_KM (FAILED): 1. Noticed that it is showing the wrong output.
TEST_CHROMIUM_KM_BS (FAILED): 1. Did not pass the test since the previous one is failed.

bharanidharanj · 2024-01-24T13:44:58Z

SUITE_TERMINAL: gnome-terminal

TEST_TERMINAL_IPA (FAILED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2125.1+mantic1) on Ubuntu 23.10 Mantic Minotaur OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the above-mentioned languages (IPA (SIL). 2. Switched to sil_ipa keyboard. 3. Opened the terminal window. 4. Typed 'n>' showed the wrong output.

ermshiperete · 2024-01-24T14:07:14Z

@bharanidharanj Do you have the patched ibus installed (dpkg -l ibus should show a version with sil in the version string). If not you'll have to add the keyman-alpha ppa (sudo add-apt-repository ppa:keymanapp/keyman-alpha) and then upgrade the packages (sudo apt upgrade). Afterwards you'll have to install Keyman for this PR again because the ppa contains a Keyman version with a higher version number, so it got upgraded.

bharanidharanj · 2024-01-24T14:11:20Z

SUITE_SEARCHBAR: Searchbar in gnome-shell

TEST_SEARCHBAR_IPA (FAILED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2125.1+mantic1) on Ubuntu 23.10 Mantic Minotaur OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the above mentioned languages (IPA (SIL), Korean KORDA Jamo, Khmer Angkor and Vedic Sanskrit Devanagari..) using Keyman Configuration dialog. 2. Pressed Windows key to open search bar. 3. Switched to sil_ipa keyboard. 5. Observed that there was no output displayed in the search bar.
TEST_SEARCHBAR_KO (PASSED): Noticed that it is showing the correct output.
TEST_SEARCHBAR_HI (FAILED): Observed that there was no output displayed in the search bar.
TEST_SEARCHBAR_KM (PASSED): Noticed that it is showing the correct output.
TEST_SEARCHBAR_KM_BS (PASSED): 1. Pressing Backspace key 5 times, removed the entire khmer_angkor word.

bharanidharanj · 2024-01-24T14:36:24Z

Test Results

SUITE_ANKI: Anki

TEST_ANKI_IPA (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2125.1+mantic1) on Ubuntu 23.10 Mantic Minotaur OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the above mentioned languages (IPA (SIL), Korean KORDA Jamo, Khmer Angkor and Vedic Sanskrit Devanagari..) using Keyman Configuration dialog. 2. Installed Anki application. 3. Opened it. Clicked Tools / Study Deck option. 4. In Study Deck window, Clicked the Search bar. 5. Switched to sil_ipa keyboard. 6. Typed 'n>' keys showed the expected output.
TEST_ANKI_KO (PASSED): Noticed that it is showing the correct output.
TEST_ANKI_HI (PASSED): Noticed that it is showing the correct output.
TEST_ANKI_KM (PASSED): Noticed that it is showing the correct output.
TEST_ANKI_KM_BS (PASSED): 1. Pressing Backspace key 5 times, removed the entire khmer_angkor word.

ermshiperete · 2024-01-25T11:27:02Z

@bharanidharanj There seem to be problems with Ubuntu 23.10 which I will look into separately. Could you please re-test with Ubuntu 22.04 Jammy? Thanks!

Also, please make sure to test in gedit which is a separate app from Text Editor - you might have to install it explicitly with sudo apt install gedit.

@keymanapp-test-bot retest SUITE_WRITER TEST_WRITER_KM TEST_WRITER_KM_BS SUITE_GEDIT TEST_GEDIT_IPA TEST_GEDIT_HI TEST_GEDIT_KM TEST_GEDIT_KM_BS SUITE_CHROMIUM TEST_CHROMIUM_IPA TEST_CHROMIUM_KO TEST_CHROMIUM_HI TEST_CHROMIUM_KM TEST_CHROMIUM_KM_BS SUITE_TERMINAL TEST_TERMINAL_IPA SUITE_SEARCHBAR TEST_SEARCHBAR_IPA TEST_SEARCHBAR_HI

bharanidharanj · 2024-01-29T10:54:35Z

@bharanidharanj There seem to be problems with Ubuntu 23.10 which I will look into separately. Could you please re-test with Ubuntu 22.04 Jammy? Thanks!

Also, please make sure to test in gedit which is a separate app from Text Editor - you might have to install it explicitly with sudo apt install gedit.

@keymanapp-test-bot retest SUITE_WRITER TEST_WRITER_KM TEST_WRITER_KM_BS SUITE_GEDIT TEST_GEDIT_IPA TEST_GEDIT_HI TEST_GEDIT_KM TEST_GEDIT_KM_BS SUITE_CHROMIUM TEST_CHROMIUM_IPA TEST_CHROMIUM_KO TEST_CHROMIUM_HI TEST_CHROMIUM_KM TEST_CHROMIUM_KM_BS SUITE_TERMINAL TEST_TERMINAL_IPA SUITE_SEARCHBAR TEST_SEARCHBAR_IPA TEST_SEARCHBAR_HI

@ermshiperete Sure. I will do it.

bharanidharanj · 2024-01-29T11:24:32Z

SUITE_CHROMIUM: Chrome/Chromium

TEST_CHROMIUM_IPA (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the sil_ipa Keyboard. 2. Opened Chromium browser. 3. Opened https://keyman.com/keyboards link. 4. Switched to sil_ipa keyboard. 5. Noticed that it is showing the correct output.
TEST_CHROMIUM_KO (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the Korean_KORDA Keyboard. 2. Opened Chromium browser. 3. Opened https://keyman.com/keyboards link. 4. Switched to korean_korda keyboard. 5. Noticed that it is showing the correct output.
TEST_CHROMIUM_HI (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the vedic_sanskrit Keyboard. 2. Opened Chromium browser. 3. Opened https://keyman.com/keyboards link. 4. Switched to vedic_sanskrit keyboard. 5. Noticed that it is showing the correct output.
TEST_CHROMIUM_KM (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the khmer_angkor Keyboard. 2. Opened Chromium browser. 3. Opened https://keyman.com/keyboards link. 4. Switched to khmer_angkor keyboard. 5. Noticed that it is showing the correct output.
TEST_CHROMIUM_KM_BS (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the khmer_angkor Keyboard. 2. Opened Chromium browser. 3. Opened https://keyman.com/keyboards link. 4. Switched to khmer_angkor keyboard. 5. With the output "ខ្មែរ" still being displayed, pressed the Backspace key 5 times. Verified that after each keystroke a part of the string is removed and after the 5th backspace the entire word was deleted.

bharanidharanj · 2024-01-29T11:31:58Z

SUITE_TERMINAL: gnome-terminal

TEST_TERMINAL_IPA (FAILED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the sil_ipa keyboard. 2. Switched to sil_ipa keyboard. 3. Opened the terminal window. 4. Typed "n>" letters. 5. Noticed that it showed the wrong output.

bharanidharanj · 2024-01-29T11:39:57Z

SUITE_SEARCHBAR: Searchbar in gnome-shell

TEST_SEARCHBAR_IPA (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the sil_ipa keyboard. 2. Switched to sil_ipa keyboard. 3. Opened the terminal window. 4. Typed "n>" letters. 5. Noticed that it showed the correct output.
TEST_SEARCHBAR_HI (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the vedic_sanskrit keyboard. 2. Switched to vedic_sanskrit keyboard. 3. Opened the terminal window. 4. Typed "shrI" letters. 5. Noticed that it showed the correct output.

bharanidharanj · 2024-01-29T11:57:41Z

SUITE_GEDIT: gedit

TEST_GEDIT_IPA (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the sil_ipa keyboard. 2. Switched to sil_ipa keyboard. 3. Opened the terminal window. 4. Typed "n>" letters. 5. Noticed that it showed the correct output.
TEST_GEDIT_HI (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the vedic_sanskrit keyboard. 2. Switched to vedic_sanskrit keyboard. 3. Opened the terminal window. 4. Typed "n>" letters. 5. Noticed that it showed the correct output.
TEST_GEDIT_KM (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the khmer_angkor keyboard. 2. Switched to khmer_angkor keyboard. 3. Opened the terminal window. 4. Typed "n>" letters. 5. Noticed that it showed the correct output.
TEST_GEDIT_KM_BS (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the khmer_angkor Keyboard. 2. Opened Text Editor. 3. Switched to khmer_angkor keyboard. 4. With the output "ខ្មែរ" still being displayed, pressed the Backspace key 5 times. Verified that after each keystroke a part of the string is removed and after the 5th backspace the entire word was deleted.

bharanidharanj · 2024-01-29T12:04:29Z

Test Results

SUITE_WRITER: LibreOffice Writer

TEST_WRITER_KM (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the khmer_angkor keyboard. 2. Switched to khmer_angkor keyboard. 3. Opened the LibreOffice Writer document. 4. Typed "xEjmr>" letters. 5. Noticed that it showed the correct output.
TEST_WRITER_KM_BS (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10480-2146.1+jammy1) on Ubuntu 22.04 Jammy Jelly fish Linux OS (vm) (Ubuntu on Xorg - x11) and here is my observation: 1. Installed the khmer_angkor keyboard. 2. Switched to khmer_angkor keyboard. 3. Opened the LibreOffice Writer document. 4. Typed "xEjmr" letters. 5. It showed the correct output. 6. With the output "ខ្មែរ" still being displayed, pressed the Backspace key 5 times. Verified that after each keystroke a part of the string is removed and after the 5th backspace the entire word was deleted.

ermshiperete · 2024-01-29T15:58:39Z

SUITE_TERMINAL: gnome-terminal

TEST_TERMINAL_IPA (SKIPPED): Fails because of bug(linux): IPA (SIL) keyboards don't work properly in gnome-terminal #10536

refactor(linux): Use km_core_state_action_items struct instead of q…

372af21

…ueue Implements #10353.

keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Jan 23, 2024

keymanapp-test-bot bot added the epic-core/9999-normalization label Jan 23, 2024

keymanapp-test-bot bot changed the title ~~refactor(linux): Use km_core_state_action_items struct instead of queue~~ refactor(linux): Use km_core_state_action_items struct instead of queue 🌱 Jan 23, 2024

keymanapp-test-bot bot added this to the A17S31 milestone Jan 23, 2024

github-actions bot added linux/ linux/engine/ refactor labels Jan 23, 2024

ermshiperete marked this pull request as ready for review January 23, 2024 16:56

ermshiperete requested a review from darcywong00 as a code owner January 23, 2024 16:56

darcywong00 reviewed Jan 24, 2024

View reviewed changes

mcdurdin changed the title ~~refactor(linux): Use km_core_state_action_items struct instead of queue 🌱~~ refactor(linux): Use km_core_actions struct instead of queue 🌱 Jan 24, 2024

mcdurdin approved these changes Jan 24, 2024

View reviewed changes

keymanapp-test-bot bot added the user-test-failed label Jan 24, 2024

refactor(linux): address code review comments

c713cd0

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jan 24, 2024

keymanapp-test-bot bot added user-test-required User tests have not been completed and removed user-test-failed labels Jan 25, 2024

chore(linux): Add more debug output

a79e64b

keymanapp-test-bot bot added the user-test-failed label Jan 29, 2024

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jan 29, 2024

Base automatically changed from fix/core/10100-ContextNuances to epic/core/9999-normalization January 29, 2024 15:52

keymanapp-test-bot bot removed the user-test-failed label Jan 29, 2024

ermshiperete merged commit 9183185 into epic/core/9999-normalization Jan 29, 2024

ermshiperete deleted the refactor/linux/10353_actionstruct branch January 29, 2024 15:59

This was referenced Feb 1, 2024

fix(core): make km_core_state_get_actions() idempotent #10585

Merged

fix(core): surrogate handling, markers in app context, and memory leak #10618

Merged

Uh oh!

Conversation

ermshiperete commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User Testing

Preparations

SUITE_WRITER: LibreOffice Writer

Tests

SUITE_GEDIT: gedit

Tests

SUITE_FIREFOX: Firefox

Tests

SUITE_CHROMIUM: Chrome/Chromium

Tests

SUITE_TERMINAL: gnome-terminal

Tests

SUITE_ANKI: Anki

Tests

SUITE_SEARCHBAR: Searchbar in gnome-shell

Tests

Uh oh!

keymanapp-test-bot bot commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User Test Results

✅ SUITE_WRITER: LibreOffice Writer

✅ SUITE_GEDIT: gedit

✅ SUITE_FIREFOX: Firefox

✅ SUITE_CHROMIUM: Chrome/Chromium

🟩 SUITE_TERMINAL: gnome-terminal

✅ SUITE_ANKI: Anki

✅ SUITE_SEARCHBAR: Searchbar in gnome-shell

Test Artifacts

Uh oh!

darcywong00 Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

mcdurdin Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

ermshiperete Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

mcdurdin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mcdurdin Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

bharanidharanj commented Jan 24, 2024

SUITE_WRITER: LibreOffice Writer

Uh oh!

bharanidharanj commented Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

SUITE_GEDIT: gedit

Uh oh!

bharanidharanj commented Jan 24, 2024

Test Results

SUITE_FIREFOX: Firefox

Uh oh!

bharanidharanj commented Jan 24, 2024

Test Results

SUITE_CHROMIUM: Chromium

Uh oh!

bharanidharanj commented Jan 24, 2024

SUITE_TERMINAL: gnome-terminal

Uh oh!

ermshiperete commented Jan 24, 2024

Uh oh!

bharanidharanj commented Jan 24, 2024

SUITE_SEARCHBAR: Searchbar in gnome-shell

Uh oh!

bharanidharanj commented Jan 24, 2024

Test Results

SUITE_ANKI: Anki

Uh oh!

ermshiperete commented Jan 25, 2024

Uh oh!

ermshiperete commented Jan 23, 2024 •

edited

Loading

keymanapp-test-bot bot commented Jan 23, 2024 •

edited

Loading

bharanidharanj commented Jan 24, 2024 •

edited

Loading

bharanidharanj commented Jan 29, 2024 •

edited

Loading

bharanidharanj commented Jan 29, 2024 •

edited

Loading