feat(developer): LDML keyboard test window marker support 🌱#10472
Merged
mcdurdin merged 7 commits intoepic/core/9999-normalizationfrom Jan 26, 2024
Merged
Conversation
…debugger Relates to #10416. Moves from using action queue to action struct for the LDML keyboard debugger. Does not do the same for the KMX keyboard debugger, because that relies on action items to do single-step debugging.
Fixes #10458. Refactors the LDML keyboard test window significantly, in order to be able to support markers. Cleans up the state machine for the debug window in the process, as that was complicating the changes. Removes a lot of extraneous code in the debug window.
User Test ResultsTest specification and instructions
Test Artifacts
|
This was
linked to
issues
Jan 23, 2024
darcywong00
reviewed
Jan 24, 2024
…t/developer/10416-10458-ldml-debugger-markers
Base automatically changed from
refactor/developer/10214-debugger-app-context
to
epic/core/9999-normalization
January 25, 2024 23:18
…-10458-ldml-debugger-markers
Rolls back the privatisation of the km_core_context_get and km_core_context_length APIs because the debugger uses them.
Member
Author
|
@bharanidharanj the branch was not up to date so we didn't have the fix for that issue you experienced applied to this PR. I have updated the branch and am rebuilding now; please retest 😄 @keymanapp-test-bot retest |
Member
Author
Test Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10458.
Fixes #10416.
Moves from using action queue to action struct for the LDML keyboard debugger. Does not do the same for the KMX keyboard debugger, because that relies on action items to do single-step debugging.
Refactors the LDML keyboard test window significantly, in order to be able to support markers. Cleans up the state machine for the debug window in the process, as that was complicating the changes. Removes a lot of extraneous code in the debug window.
User Testing
hello!\m{3}in the character previewCongratulations!b,\m{2}in the character previewsample keyboard