fix(android/engine): Fix OSK widths by darcywong00 · Pull Request #10442 · keymanapp/keyman

darcywong00 · 2024-01-19T00:44:53Z

Follows #10373 and fixes #10241

This applies two things to fix OSK width to be full screen

Disables multi-window mode for the entire Keyman app
Refactors detection of device orientation so MainActivity.onResume() has the correct dimensions for the OSK

User Testing

Setup - Install the PR build of Keyman for Android on an Android 12.0 device /emulator (SDK 31)

TEST_OSK - Verifies OSK is full width after using keyboard picker

Launch Keyman for Android in landscape
Type some letters on the input text screen.
Longpress the globe key to open the Keyboard picker menu.
Click the default keyboard.
Verify the app shows the OSK full-width.

keymanapp-test-bot · 2024-01-19T00:45:05Z

User Test Results

Test specification and instructions

✅ TEST_OSK (PASSED): Tested with the attached PR build (Keyman 17.0.251-alpha-test-10442) in the Android 12 / API 31 emulator and here is my observation: 1. Launched the Keyman in Landscape. 2. Closed the "Get Started" dialog. 3. Typed some letters on the text input screen. 4. Opened the Keyboard picker menu by long-pressing the globe key. 5. Clicked the default keyboard. 6. Verified that the app shows the OSK in full-width. (notes)

Test Artifacts

Android

bharanidharanj · 2024-01-19T06:12:55Z

Test Results

TEST_OSK (FAILED): Tested with the attached PR build (Keyman 17.0.248-alpha-test-10442) in the Android emulator (ver 12 / AP31) and here is my observation: 1. Keyman app abruptly closed after launching it from the landscape mode. 2. However, it works fine after restarting the emulator. 3. Tried the same steps in the Android Mobile and I am getting the same issue.

darcywong00 · 2024-01-19T08:26:11Z

Sigh - this needs more investigation. I also notice when rotating to landscape, the menu options don't display the landscape layout 😖

darcywong00 · 2024-01-24T06:19:14Z

The refactoring of detecting the device orientation seems to work now.

@keymanapp-test-bot retest

darcywong00 · 2024-01-24T06:31:18Z

android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/MainActivity.java


    // onConfigurationChanged() only triggers when device is rotated while app is in foreground
    // This handles when device is rotated while app is in background
+    // using KMManager.getOrientation() since getConfiguration().orientation is unreliable #10241


getResources().getconfiguration() was sometimes reporting PORTRAIT when the device was in LANDSCAPE orientation.

mcdurdin · 2024-01-24T06:39:47Z

android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/MainActivity.java

    Configuration newConfig = this.getResources().getConfiguration();
-    if (newConfig != null && newConfig.orientation != lastOrientation) {
-      lastOrientation = newConfig.orientation;
+    int newOrientation = KMManager.getOrientation(context);
+    if (newOrientation != lastOrientation) {
+      lastOrientation = newOrientation;
      KMManager.onConfigurationChanged(newConfig);
    }


This retrieves newConfig but never tests it. Given it may have a wrong orientation, is this going to cause grief when passing it to onConfigurationChanged().
Also, I would move line 271 ... newConfig = ... inside the if() { statement before line 275 in order to keep its scope limited

I retested the scenarios from #8704 and they seemed fine (restarting the app after rotating the device while the app is in the background).
lastOrientation is undefined so the app goes into this branch and refreshes with the correct dimensions. Maybe getOrientation() is the only buggy part?

android/KMEA/app/src/main/java/com/keyman/engine/KMManager.java

darcywong00 · 2024-01-24T07:43:02Z

Answer @mcdurdin 's question from standup:

How is the OSK handled if the device is rotated when the orientation is locked into PORTRAIT or LANDSCAPE?

I tested with my physical device locked in PORTRAIT and then locked in LANDSCAPE. Good news is the app and OSK remain locked in the orientation.

bharanidharanj · 2024-01-24T10:24:35Z

Test Results

TEST_OSK (PASSED): Tested with the attached PR build (Keyman 17.0.251-alpha-test-10442) in the Android 12 / API 31 emulator and here is my observation: 1. Launched the Keyman in Landscape. 2. Closed the "Get Started" dialog. 3. Typed some letters on the text input screen. 4. Opened the Keyboard picker menu by long-pressing the globe key. 5. Clicked the default keyboard. 6. Verified that the app shows the OSK in full-width.

Added some refactoring

android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/AdjustKeyboardHeightActivity.java

mcdurdin · 2024-01-25T03:48:08Z

android/KMEA/app/src/main/java/com/keyman/engine/KMManager.java

+    if (orientation == Configuration.ORIENTATION_PORTRAIT) {
      return prefs.getInt(KMManager.KMKey_KeyboardHeightPortrait, defaultHeight);
-    } else if (rotation == Surface.ROTATION_90 || rotation == Surface.ROTATION_270) {
+    } else if (orientation == Configuration.ORIENTATION_LANDSCAPE) {


What do we do if ORIENTATION_UNDEFINED is returned? Seems like we fall into a hole?

The defaultHeight initializes in l. 2023 so that value gets returned in l. 2033. I think typically that will be the portrait dimensions

Co-authored-by: Marc Durdin <marc@durdin.net>

keyman-server · 2024-01-25T18:08:40Z

Changes in this pull request will be available for download in Keyman version 17.0.252-alpha

darcywong00 requested a review from sgschantz as a code owner January 19, 2024 00:44

keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Jan 19, 2024

github-actions bot added android/ android/app/ fix labels Jan 19, 2024

keymanapp-test-bot bot added this to the A17S30 milestone Jan 19, 2024

mcdurdin previously approved these changes Jan 19, 2024

View reviewed changes

keymanapp-test-bot bot added user-test-failed and removed user-test-required User tests have not been completed labels Jan 19, 2024

darcywong00 marked this pull request as draft January 19, 2024 08:26

mcdurdin modified the milestones: A17S30, A17S31 Jan 20, 2024

github-actions bot added the android/engine/ label Jan 22, 2024

darcywong00 added 3 commits January 24, 2024 12:53

fix(android/app): Apply resizeableActivity to entire app

338a8ac

fix(android/engine): Try other settings to fix OSK width

4785c6b

refactor(android/engine): Refactor detection of device orientation

4718b5b

darcywong00 force-pushed the fix/android/landscape-kb-picker-osk branch from 8f634d6 to 4718b5b Compare January 24, 2024 05:54

darcywong00 changed the title ~~fix(android/app): Apply resizeableActivity to entire app~~ fix(android/engine): Fix OSK widths Jan 24, 2024

keymanapp-test-bot bot added user-test-required User tests have not been completed and removed user-test-failed labels Jan 24, 2024

darcywong00 marked this pull request as ready for review January 24, 2024 06:20

darcywong00 commented Jan 24, 2024

View reviewed changes

chore(android/engine): Revert KMKeyboard change

72bcb30

mcdurdin reviewed Jan 24, 2024

View reviewed changes

chore(android/app): Move scope of newConfig

4cffe74

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jan 24, 2024

mcdurdin reviewed Jan 25, 2024

View reviewed changes

android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/AdjustKeyboardHeightActivity.java Outdated Show resolved Hide resolved

mcdurdin approved these changes Jan 25, 2024

View reviewed changes

Apply suggestions from code review

e2b8cf3

Co-authored-by: Marc Durdin <marc@durdin.net>

darcywong00 merged commit 811ea81 into master Jan 25, 2024

darcywong00 deleted the fix/android/landscape-kb-picker-osk branch January 25, 2024 04:38

darcywong00 mentioned this pull request May 23, 2024

docs: Add getOrientation, getWindowDensity, and getWindowSize APIs keymanapp/help.keyman.com#1270

Merged

jahorton mentioned this pull request May 23, 2024

fix(android): Resize keyboard on orientation change #11484

Closed

Uh oh!

Conversation

darcywong00 commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User Testing

Uh oh!

keymanapp-test-bot bot commented Jan 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User Test Results

Test Artifacts

Uh oh!

bharanidharanj commented Jan 19, 2024

Test Results

Uh oh!

darcywong00 commented Jan 19, 2024

Uh oh!

darcywong00 commented Jan 24, 2024

Uh oh!

darcywong00 Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

mcdurdin Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

darcywong00 Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

darcywong00 commented Jan 24, 2024

Uh oh!

bharanidharanj commented Jan 24, 2024

Test Results

Uh oh!

Uh oh!

mcdurdin Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

darcywong00 Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

keyman-server commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

darcywong00 commented Jan 19, 2024 •

edited

Loading

keymanapp-test-bot bot commented Jan 19, 2024 •

edited

Loading