fix(core): Fix nuances when updating context 🌱 by ermshiperete · Pull Request #10439 · keymanapp/keyman

ermshiperete · 2024-01-18T18:44:21Z

Fixes #10100.

User Testing

Preparations

The tests should be run on Linux, Windows and Mac.
Install build artifacts of this PR. (Instructions for Linux)
on Linux install the .deb version of Firefox and/or Chrome/Chromium and remove the snap version
Reboot

Tests

GROUP_WIN: Windows
GROUP_MAC: macOS
GROUP_LINUX: Ubuntu 22.04 with X11

Open https://keyman.com/keyboards in a browser and run the following tests:

TEST_KHMER_ANGKOR: Khmer Angkor
- Ensure the key combination AltGr B produces ឞ. Note that on macOS, the function key to use is right option.
- Type the following (US) keys in sequence: s u j r k. You should see ស្រុក.
TEST_SIL_EURO_LATIN: SIL Euro Latin
- Type % a. Ensure the output is ǎ
TEST_GALAXIE_HEBREW: Galaxie Hebrew or another good SIL RTL keyboard
- Type b \ = r @ a v ! y t (note the third-last key is the exclamation mark!) to output בְּרֵאשִׁית. FAILED if the output is different.
TEST_SIL_IPA: sil_ipa
- Ensure the key sequence n > produces ŋ.
TEST_CJK_IMX: Korean KORDA Jamo (SIL)
- Type h a n <space> g e u l <space>. Verify that the result is 한글.

keymanapp-test-bot · 2024-01-18T18:44:46Z

User Test Results

Test specification and instructions

✅ GROUP_WIN: Windows
5 tests PASSED
- ✅ TEST_KHMER_ANGKOR (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on Windows 10 OS and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Mozilla Firefox and Chrome browsers. 3. Opened https://keyman.com/keyboards test page. 4. Switched to khmer_angkor keyboard. 5. Verified it is showing the correct output. (notes)
- ✅ TEST_SIL_EURO_LATIN (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on Windows 10 OS and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Mozilla Firefox and Chrome browsers. 3. Opened https://keyman.com/keyboards test page. 4. Switched to sil_eurolatin keyboard. 5. Verified it is showing the correct output. (notes)
- ✅ TEST_GALAXIE_HEBREW (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on Windows 10 OS and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Mozilla Firefox and Chrome browsers. 3. Opened https://keyman.com/keyboards test page. 4. Switched to glaxie_hebrew keyboard. 5. Verified it is showing the correct output. (notes)
- ✅ TEST_SIL_IPA (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on Windows 10 OS and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Mozilla Firefox and Chrome browsers. 3. Opened https://keyman.com/keyboards test page. 4. Switched to sil_ipa keyboard. 5. Verified it is showing the correct output. (notes)
- ✅ TEST_CJK_IMX (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on Windows 10 OS and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Mozilla Firefox and Chrome browsers. 3. Opened https://keyman.com/keyboards test page. 4. Switched to Korean_KORDA keyboard. 5. Verified it is showing the correct output. (notes)
✅ GROUP_MAC: macOS
5 tests PASSED
- ✅ TEST_KHMER_ANGKOR (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-test-10439) in macOS Sonoma and here is my observation: 1. Installed khmer_angkor keyboard. 2. Opened keyman.com/keyboards page. 3. Switched to Khmer_Angkor keyboard. 5. Verified it is showing the correct output.
- ✅ TEST_SIL_EURO_LATIN (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on macOS Sonoma and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Chrome browser. 3. Opened Slatejs test page. 4. Switched to sil_eurolatin keyboard. 5. Verified it is showing the correct output. (notes)
- ✅ TEST_GALAXIE_HEBREW (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on macOS Sonoma and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Chrome browser. 3. Opened Slatejs test page. 4. Switched to Galaxie_Hebrew keyboard. 5. Verified it is showing the correct output. (notes)
- ✅ TEST_SIL_IPA (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on macOS Sonoma and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Chrome browser. 3. Opened Slatejs test page. 4. Switched to sil_ipa keyboard. 5. Verified it is showing the correct output. (notes)
- ✅ TEST_CJK_IMX (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-test-10439) in macOS Sonoma and here is my observation: 1. Installed khmer_angkor keyboard. 2. Opened keyman.com/keyboards page. 3. Switched to Korean_KORDA keyboard. 5. Verified it is showing the correct output.
✅ GROUP_LINUX: Ubuntu 22.04 with X11
5 tests PASSED
- ✅ TEST_KHMER_ANGKOR (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2114.1+jammy1) in Ubuntu 22.04 Jammy Jelly Fish Linux OS (VM) and here is my observation: 1. Installed khmer_angkor keyboard. 2. Opened keyman.com/keyboards page. 3. Switched to Khmer_Angkor keyboard. 5. Verified it is showing the correct output.
- ✅ TEST_SIL_EURO_LATIN (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2114.1+jammy1) in Ubuntu 22.04 Jammy Jelly Fish Linux OS (VM) and here is my observation: 1. Installed sil_euro keyboard. 2. Opened keyman.com/keyboards page. 3. Switched to sil_eurolatin keyboard. 5. Verified it is showing the correct output.
- ✅ TEST_GALAXIE_HEBREW (PASSED): It is showing the correct output. (notes)
- ✅ TEST_SIL_IPA (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2114.1+jammy1) in Ubuntu 22.04 Jammy Jelly Fish Linux OS (VM) and here is my observation: 1. Installed sil_ipa keyboard. 2. Opened keyman.com/keyboards page. 3. Switched to sil_ipa keyboard. 5. Verified it is showing the correct output.
- ✅ TEST_CJK_IMX (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2114.1+jammy1) in Ubuntu 22.04 Jammy Jelly Fish Linux OS (VM) and here is my observation: 1. Installed Korean_KORDA keyboard. 2. Opened keyman.com/keyboards page. 3. Switched to Korean_KORDA keyboard. 5. Verified it is showing the correct output.

Test Artifacts

Fixes #10100.

mcdurdin

LGTM, a couple of minor niggles

core/src/km_core_state_context_set_if_needed.cpp

bharanidharanj · 2024-01-22T11:36:50Z

Test Results

TEST_KHMER_ANGKOR (FAILED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2102.1+mantic1) in Ubuntu 23.10 Mantic Minotaur Linux OS (VM) and here is my observation: 1. Installed Khmer Angkor keyboard. 2. Opened Slate.js text editor page. 3. Typed "sujrk" showed the wrong output in Chrome browser.

..working in Firefox browser and not working in Chrome browser

bharanidharanj · 2024-01-22T11:40:45Z

Test Results

TEST_SIL_EURO_LATIN (FAILED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2102.1+mantic1) in Ubuntu 23.10 Mantic Minotaur Linux OS (VM) and here is my observation: 1. Installed sil_euro_latin keyboard. 2. Opened Slate.js text editor page. 3. Typed "%a" showed the wrong output in both Mozilla Firefox and Chrome browsers.

bharanidharanj · 2024-01-22T11:45:18Z

Test Results

TEST_GALAXIE_HEBREW (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2102.1+mantic1) in Ubuntu 23.10 Mantic Minotaur Linux OS (VM) and here is my observation : 1. Installed Galaxy_Hebrew keyboard. 2. Opened Slate.js text editor page. 3. Typed "b=r@av!yt" showed the correct output in both Mozilla Firefox and Chrome browsers.

bharanidharanj · 2024-01-22T11:48:14Z

Test Results

TEST_SIL_IPA (FAILED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2102.1+mantic1) in Ubuntu 23.10 Mantic Minotaur Linux OS (VM) and here is my observation: 1. Installed sil_ipa keyboard. 2. Opened Slate.js text editor page. 3. Typed "n>" showed the wrong output in both Mozilla Firefox and Chrome browsers.

bharanidharanj · 2024-01-22T12:05:17Z

Test Results

TEST_INTERACTION_WITH_TEXT_FORMATTING (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2102.1+mantic1) in Ubuntu 23.10 Mantic Minotaur Linux OS (VM) and here is my observation: 1. Installed khmer_angkor keyboard. 2. Opened Slate.js text editor page. 3. Pressed Ctrl+B to make the letter bold. 4. Typed "sujrk" or "b" showed the texts that appeared in bold letters in both Mozilla Firefox and Chrome browsers.

bharanidharanj · 2024-01-22T12:12:10Z

Test Results

TEST_CJK_IMX (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2102.1+mantic1) in Ubuntu 23.10 Mantic Minotaur Linux OS (VM) and here is my observation : 1. Installed Korean_Korda Jamo (SIL) keyboard. 2. Opened Slate js text editor page. 3. Typed "hangeul" showed wrong output in both Mozilla Firefox and Chrome browsers.

ermshiperete · 2024-01-23T15:24:26Z

@bharanidharanj It looks like you're using the snap version of Firefox and Chrome/Chromium. Please remove them and install the .deb versions. You can run these commands in a terminal:

sudo snap remove firefox
sudo add-apt-repository ppa:mozillateam/ppa
echo '
Package: *
Pin: release o=LP-PPA-mozillateam
Pin-Priority: 1001
' | sudo tee /etc/apt/preferences.d/mozilla-firefox
echo 'Unattended-Upgrade::Allowed-Origins:: "LP-PPA-mozillateam:${distro_codename}";'  | sudo tee /etc/apt/apt.conf.d/51unattended-upgrades-firefox
sudo apt install firefox

and

sudo snap remove chromium-browser
wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
sudo apt install ./google-chrome-stable_current_amd64.deb

Also, make sure you're testing with X11 (on Wayland there's a different bug #10476 that affects testing of this PR).

@keymanapp-test-bot retest

bharanidharanj · 2024-01-24T06:22:25Z

@bharanidharanj It looks like you're using the snap version of Firefox and Chrome/Chromium. Please remove them and install the .deb versions. You can run these commands in a terminal:
sudo snap remove firefox
sudo add-apt-repository ppa:mozillateam/ppa
echo '
Package: *
Pin: release o=LP-PPA-mozillateam
Pin-Priority: 1001
' | sudo tee /etc/apt/preferences.d/mozilla-firefox
echo 'Unattended-Upgrade::Allowed-Origins:: "LP-PPA-mozillateam:${distro_codename}";'  | sudo tee /etc/apt/apt.conf.d/51unattended-upgrades-firefox
sudo apt install firefox
and
sudo snap remove chromium-browser
wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
sudo apt install ./google-chrome-stable_current_amd64.deb
Also, make sure you're testing with X11 (on Wayland there's a different bug #10476 that affects testing of this PR).

@keymanapp-test-bot retest

@ermshiperete Sure. Thanks for your suggestion.

bharanidharanj · 2024-01-25T11:33:05Z

Test Results

GROUP_WIN: Windows

TEST_KHMER_ANGKOR (FAILED): Tested with the attached PR build (Keyman 17.0.245-alpha-test-10439) on Window 10 OS and here is my observation: 1. Installed Khmer_Angkor keyboard. 2. Opened Slate Examples page. 3. Typed 'sujrk' and it is showing the wrong output.
TEST_SIL_EURO_LATIN (FAILED): It is showing the wrong output.
TEST_GALAXIE_HEBREW (FAILED): It is showing the wrong output.
TEST_SIL_IPA (FAILED): It is showing the wrong output.
TEST_INTERACTION_WITH_TEXT_FORMATTING (PASSED): It is showing the correct output.
TEST_CJK_IMX (FAILED): It is showing the wrong output.

bharanidharanj · 2024-01-25T12:38:04Z

GROUP_LINUX: Linux

TEST_KHMER_ANGKOR (FAILED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2114.1+mantic1) on Ubuntu 23.10 Mantic Linux OS (VM) and here is my observation: 1. Installed Mozilla Firefox and Chromium browsers (.deb versions) as per your suggestions. 2. Installed the Keyboard as mentioned in the PR. 3. Verified it in both Mozilla Firefox and Chrome browsers showing the wrong output in Chrome browser.
TEST_SIL_EURO_LATIN (FAILED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2114.1+mantic1) on Ubuntu 23.10 Mantic Linux OS (VM) and here is my observation: 1. Installed Mozilla Firefox and Chromium browsers (.deb versions) as per your suggestions. 2. Installed the Keyboard as mentioned in the PR. 3. Verified it in both Mozilla Firefox and Chrome browsers showing the wrong output in Chrome browser.
TEST_GALAXIE_HEBREW (PASSED): It is showing the correct output.
TEST_SIL_IPA (FAILED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2114.1+mantic1) on Ubuntu 23.10 Mantic Linux OS (VM) and here is my observation: 1. Installed Mozilla Firefox and Chromium browsers (.deb versions) as per your suggestions. 2. Installed the Keyboard as mentioned in the PR. 3. Verified it in both Mozilla Firefox and Chrome browsers showing the wrong output in Chrome browser.
TEST_INTERACTION_WITH_TEXT_FORMATTING (PASSED): It is showing the correct output.
TEST_CJK_IMX (FAILED): Tested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2114.1+mantic1) on Ubuntu 23.10 Mantic Linux OS (VM) and here is my observation: 1. Installed Mozilla Firefox and Chromium browsers (.deb versions) as per your suggestions. 2. Installed the Keyboard as mentioned in the PR. 3. Verified it in both Mozilla Firefox and Chrome browsers showing the wrong output in Chrome browser.

bharanidharanj · 2024-01-25T13:11:17Z

Test Results

GROUP_MAC: macOS

TEST_KHMER_ANGKOR (FAILED): Tested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on macOS Sonoma and here is my observation: 1. Installed the above-mentioned keyboards in the system. 2. Opened Chrome browser. 3. Opened Slatejs test page. 4. Switched to Khmer_Angkor keyboard. 5. Verified it is showing the wrong output.
TEST_SIL_EURO_LATIN (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on macOS Sonoma and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Chrome browser. 3. Opened Slatejs test page. 4. Switched to sil_eurolatin keyboard. 5. Verified it is showing the correct output.
TEST_GALAXIE_HEBREW (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on macOS Sonoma and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Chrome browser. 3. Opened Slatejs test page. 4. Switched to Galaxie_Hebrew keyboard. 5. Verified it is showing the correct output.
TEST_SIL_IPA (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on macOS Sonoma and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Chrome browser. 3. Opened Slatejs test page. 4. Switched to sil_ipa keyboard. 5. Verified it is showing the correct output.
TEST_INTERACTION_WITH_TEXT_FORMATTING (PASSED): Tested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on macOS Sonoma and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Chrome browser. 3. Opened Slatejs test page. 4. Verified it is showing the bold letters.
TEST_CJK_IMX (FAILED): Tested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on macOS Sonoma and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Chrome browser. 3. Opened Slatejs test page. 4. Switched to Korean KORDA keyboard. 5. Verified it is showing the wrong output.

ermshiperete · 2024-01-25T16:15:35Z

@bharanidharanj Sorry, should have told you not to test with slate.js since that has bug. Could you please retest using the input field in keyman.com/keyboards instead? Thanks!

@keymanapp-test-bot retest GROUP_WIN TEST_KHMER_ANGKOR TEST_SIL_EURO_LATIN TEST_GALAXIE_HEBREW TEST_SIL_IPA TEST_CJK_IMX GROUP_MAC TEST_KHMER_ANGKOR TEST_CJK_IMX GROUP_LINUX TEST_KHMER_ANGKOR TEST_SIL_EURO_LATIN TEST_SIL_IPA TEST_CJK_IMX

bharanidharanj · 2024-01-29T07:52:00Z

@bharanidharanj Sorry, should have told you not to test with slate.js since that has bug. Could you please retest using the input field in keyman.com/keyboards instead? Thanks!

@keymanapp-test-bot retest GROUP_WIN TEST_KHMER_ANGKOR TEST_SIL_EURO_LATIN TEST_GALAXIE_HEBREW TEST_SIL_IPA TEST_CJK_IMX GROUP_MAC TEST_KHMER_ANGKOR TEST_CJK_IMX GROUP_LINUX TEST_KHMER_ANGKOR TEST_SIL_EURO_LATIN TEST_SIL_IPA TEST_CJK_IMX

@ermshiperete Sure, I will do it.

bharanidharanj · 2024-01-29T09:18:58Z

Test Results

GROUP_WIN: Windows

TEST_KHMER_ANGKOR (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on Windows 10 OS and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Mozilla Firefox and Chrome browsers. 3. Opened https://keyman.com/keyboards test page. 4. Switched to khmer_angkor keyboard. 5. Verified it is showing the correct output.
TEST_SIL_EURO_LATIN (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on Windows 10 OS and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Mozilla Firefox and Chrome browsers. 3. Opened https://keyman.com/keyboards test page. 4. Switched to sil_eurolatin keyboard. 5. Verified it is showing the correct output.
TEST_GALAXIE_HEBREW (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on Windows 10 OS and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Mozilla Firefox and Chrome browsers. 3. Opened https://keyman.com/keyboards test page. 4. Switched to glaxie_hebrew keyboard. 5. Verified it is showing the correct output.
TEST_SIL_IPA (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on Windows 10 OS and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Mozilla Firefox and Chrome browsers. 3. Opened https://keyman.com/keyboards test page. 4. Switched to sil_ipa keyboard. 5. Verified it is showing the correct output.
TEST_CJK_IMX (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-test-10439 on Windows 10 OS and here is my observation: 1. Installed the above mentioned keyboards in the system. 2. Opened Mozilla Firefox and Chrome browsers. 3. Opened https://keyman.com/keyboards test page. 4. Switched to Korean_KORDA keyboard. 5. Verified it is showing the correct output.

bharanidharanj · 2024-01-29T10:16:57Z

GROUP_LINUX: Ubuntu 22.04 with X11

TEST_KHMER_ANGKOR (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2114.1+jammy1) in Ubuntu 22.04 Jammy Jelly Fish Linux OS (VM) and here is my observation: 1. Installed khmer_angkor keyboard. 2. Opened keyman.com/keyboards page. 3. Switched to Khmer_Angkor keyboard. 5. Verified it is showing the correct output.
TEST_SIL_EURO_LATIN (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2114.1+jammy1) in Ubuntu 22.04 Jammy Jelly Fish Linux OS (VM) and here is my observation: 1. Installed sil_euro keyboard. 2. Opened keyman.com/keyboards page. 3. Switched to sil_eurolatin keyboard. 5. Verified it is showing the correct output.
TEST_SIL_IPA (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2114.1+jammy1) in Ubuntu 22.04 Jammy Jelly Fish Linux OS (VM) and here is my observation: 1. Installed sil_ipa keyboard. 2. Opened keyman.com/keyboards page. 3. Switched to sil_ipa keyboard. 5. Verified it is showing the correct output.
TEST_CJK_IMX (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-local (package version 17.0.245-1~PR-10439-2114.1+jammy1) in Ubuntu 22.04 Jammy Jelly Fish Linux OS (VM) and here is my observation: 1. Installed Korean_KORDA keyboard. 2. Opened keyman.com/keyboards page. 3. Switched to Korean_KORDA keyboard. 5. Verified it is showing the correct output.

bharanidharanj · 2024-01-29T10:30:41Z

Test Results

GROUP_MAC: macOS

TEST_KHMER_ANGKOR (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-test-10439) in macOS Sonoma and here is my observation: 1. Installed khmer_angkor keyboard. 2. Opened keyman.com/keyboards page. 3. Switched to Khmer_Angkor keyboard. 5. Verified it is showing the correct output.
TEST_CJK_IMX (PASSED): Retested with the attached PR build (Keyman 17.0.245-alpha-test-10439) in macOS Sonoma and here is my observation: 1. Installed khmer_angkor keyboard. 2. Opened keyman.com/keyboards page. 3. Switched to Korean_KORDA keyboard. 5. Verified it is showing the correct output.

…alization' into fix/core/10100-ContextNuances # Conflicts: # core/tests/unit/kmnkbd/state_context_api.cpp

github-actions bot added core/ Keyman Core fix labels Jan 18, 2024

keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Jan 18, 2024

keymanapp-test-bot bot added the epic-core/9999-normalization label Jan 18, 2024

keymanapp-test-bot bot changed the title ~~fix(core): Fix nuances when updating context~~ fix(core): Fix nuances when updating context 🌱 Jan 18, 2024

keymanapp-test-bot bot added this to the A17S30 milestone Jan 18, 2024

ermshiperete force-pushed the fix/core/10100-ContextNuances branch 3 times, most recently from 106a2b2 to 98ef895 Compare January 18, 2024 18:52

mcdurdin linked an issue Jan 18, 2024 that may be closed by this pull request

bug(core): km_core_state_context_set_if_needed needs more nuance for when to update cache 🌱 #10100

Closed

ermshiperete force-pushed the fix/core/10100-ContextNuances branch 2 times, most recently from eeb90b3 to 3c360af Compare January 19, 2024 13:15

keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed and removed user-test-missing User tests have not yet been defined for the PR labels Jan 19, 2024

fix(core): Fix nuances when updating context

a4c9404

Fixes #10100.

ermshiperete force-pushed the fix/core/10100-ContextNuances branch from 3c360af to a4c9404 Compare January 19, 2024 14:56

ermshiperete marked this pull request as ready for review January 19, 2024 14:57

ermshiperete requested review from mcdurdin and rc-swag as code owners January 19, 2024 14:57

mcdurdin modified the milestones: A17S30, A17S31 Jan 20, 2024

mcdurdin approved these changes Jan 22, 2024

View reviewed changes

chore(core): Address code review comments

4fa014a

keymanapp-test-bot bot added the user-test-failed label Jan 22, 2024

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jan 22, 2024

keymanapp-test-bot bot added user-test-required User tests have not been completed and removed user-test-failed labels Jan 23, 2024

Base automatically changed from refactor/core/10431-remove-unused-core-context-apis to epic/core/9999-normalization January 24, 2024 04:41

keymanapp-test-bot bot added the user-test-failed label Jan 25, 2024

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jan 25, 2024

keymanapp-test-bot bot added user-test-required User tests have not been completed and removed user-test-failed labels Jan 25, 2024

keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Jan 29, 2024

ermshiperete added 2 commits January 29, 2024 12:05

chore(core): Merge remote-tracking branch 'origin/epic/core/9999-norm…

5404c02

…alization' into fix/core/10100-ContextNuances # Conflicts: # core/tests/unit/kmnkbd/state_context_api.cpp

chore(core): Fix build failures

2ebca10

ermshiperete merged commit 7ec33eb into epic/core/9999-normalization Jan 29, 2024

ermshiperete deleted the fix/core/10100-ContextNuances branch January 29, 2024 15:52

Uh oh!

Conversation

ermshiperete commented Jan 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User Testing

Preparations

Tests

Uh oh!

keymanapp-test-bot bot commented Jan 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User Test Results

Test Artifacts

Uh oh!

mcdurdin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bharanidharanj commented Jan 22, 2024

Test Results

Uh oh!

bharanidharanj commented Jan 22, 2024

Test Results

Uh oh!

bharanidharanj commented Jan 22, 2024

Test Results

Uh oh!

bharanidharanj commented Jan 22, 2024

Test Results

Uh oh!

bharanidharanj commented Jan 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

bharanidharanj commented Jan 22, 2024

Test Results

Uh oh!

ermshiperete commented Jan 23, 2024

Uh oh!

bharanidharanj commented Jan 24, 2024

Uh oh!

bharanidharanj commented Jan 25, 2024

Test Results

GROUP_WIN: Windows

Uh oh!

bharanidharanj commented Jan 25, 2024

GROUP_LINUX: Linux

Uh oh!

bharanidharanj commented Jan 25, 2024

Test Results

GROUP_MAC: macOS

Uh oh!

ermshiperete commented Jan 25, 2024

Uh oh!

bharanidharanj commented Jan 29, 2024

Uh oh!

bharanidharanj commented Jan 29, 2024

Test Results

GROUP_WIN: Windows

Uh oh!

bharanidharanj commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GROUP_LINUX: Ubuntu 22.04 with X11

Uh oh!

bharanidharanj commented Jan 29, 2024

Test Results

GROUP_MAC: macOS

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ermshiperete commented Jan 18, 2024 •

edited

Loading

keymanapp-test-bot bot commented Jan 18, 2024 •

edited

Loading

bharanidharanj commented Jan 22, 2024 •

edited

Loading

bharanidharanj commented Jan 29, 2024 •

edited

Loading