Skip to content

refactor(linux): use km_core_state_context_debug 🌱#10379

Merged
mcdurdin merged 1 commit intoepic/core/9999-normalizationfrom
refactor/linux/10365-context-debug
Jan 16, 2024
Merged

refactor(linux): use km_core_state_context_debug 🌱#10379
mcdurdin merged 1 commit intoepic/core/9999-normalizationfrom
refactor/linux/10365-context-debug

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

Relates to #10365.
Fixes #10378.

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Jan 15, 2024

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Linux
    • Keyman for Linux - build failure

@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S30 milestone Jan 15, 2024
@mcdurdin mcdurdin linked an issue Jan 15, 2024 that may be closed by this pull request
@mcdurdin mcdurdin force-pushed the refactor/linux/10365-context-debug branch from 1b44b64 to 49f9937 Compare January 15, 2024 01:05
@mcdurdin mcdurdin force-pushed the refactor/linux/10365-context-debug branch from 49f9937 to 307f7da Compare January 15, 2024 01:27
@mcdurdin mcdurdin marked this pull request as ready for review January 15, 2024 06:31
@srl295 srl295 self-requested a review January 15, 2024 17:20
for (int i = 0; i < buf_size16 - 1; i++) {
g_string_append_printf(output, "U+%04x ", current_context_utf16[i]);

km_core_cp *buf = km_core_state_context_debug(keyman->state, KM_CORE_DEBUG_CONTEXT_CACHED);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and compact!

@mcdurdin
Copy link
Copy Markdown
Member Author

Debian Packaging build failure will be corrected during/after merge (libkeymancore.symbols)

@mcdurdin mcdurdin changed the title refactor(linux): use km_core_state_context_debug refactor(linux): use km_core_state_context_debug 🌱 Jan 15, 2024
Base automatically changed from feat/core/10365-context-debug to epic/core/9999-normalization January 16, 2024 02:38
@mcdurdin mcdurdin merged commit 166e4bc into epic/core/9999-normalization Jan 16, 2024
@mcdurdin mcdurdin deleted the refactor/linux/10365-context-debug branch January 16, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(linux): memory leak using g_autofree

3 participants