Merged
Conversation
- markers/normalization really needs its own file - split out ldml_markers.* from ldml_transforms.* - split out ldml_utils.hpp for a common assert macro #10320
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
…e/10320-refactor-epic-ldml
Base automatically changed from
feat/core/10320-stack-markers-epic-ldml
to
master
January 11, 2024 15:40
…refactor-epic-ldml - reapply 0d9f543 code review comments
Member
Author
|
of course the comments in 0d9f543 were on the refactord files |
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.243-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10320
@keymanapp-test-bot skip