chore(web): build script cleanup 🐵#10195
Merged
jahorton merged 3 commits intofeature-gesturesfrom Dec 12, 2023
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required |
Base automatically changed from
chore/merge-master-into-feature-gestures
to
feature-gestures
December 8, 2023 16:06
ermshiperete
approved these changes
Dec 8, 2023
mcdurdin
approved these changes
Dec 9, 2023
Co-authored-by: Marc Durdin <marc@durdin.net>
Co-authored-by: Marc Durdin <marc@durdin.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed upon a review of a recent merge of master into the feature-branch - web's build.sh had "temp" code to ensure the gesture engine was built when it wasn't connected. It is connected now, via our build-script dependency system, so we no longer need that "temp" code.
@keymanapp-test-bot skip