feat(developer): New Project opens in new process 🦕#10155
Merged
Conversation
Fixes #10138. If the current instance of Keyman Developer already has a project open, then the New Project dialog will now open the new project in a new instance of Keyman Developer. Note: this also moves a couple of functions out of dmActionsMain and into UfrmMain, as their functionality belongs more closely there. The `TmodActionsMain.OpenProject` function has been renamed to `TfrmMain.OpenProjectInCurrentProcess` to clarify its usage and context.
User Test ResultsTest specification and instructions
Test Artifacts
|
69 tasks
Test Results
|
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.229-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10138.
If the current instance of Keyman Developer already has a project open, then the New Project dialog will now open the new project in a new instance of Keyman Developer.
Note: this also moves a couple of functions out of dmActionsMain and into UfrmMain, as their functionality belongs more closely there. The
TmodActionsMain.OpenProjectfunction has been renamed toTfrmMain.OpenProjectInCurrentProcessto clarify its usage and context.User Testing
TEST_NEW_PROJECT: Open Keyman Developer, and open a project. Create a new project, and verify that the new project opens in a new instance of Keyman Developer.
TEST_NEW_PROJECT_NO_PROJECT_OPEN: Open Keyman Developer, and make sure no project is open (Project|Close Project). Create a new project, and verify that the project opens in the current instance of Keyman Developer.