Skip to content

feat(developer): Add Window menu 🦕#10154

Merged
mcdurdin merged 2 commits intomasterfrom
feat/developer/10149-window-menu
Dec 12, 2023
Merged

feat(developer): Add Window menu 🦕#10154
mcdurdin merged 2 commits intomasterfrom
feat/developer/10149-window-menu

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin commented Dec 6, 2023 •
edited
Loading

Fixes #10149.

Adds a Window menu so user can easily switch between Keyman Developer processes or open a new instance.

image

User Testing

  • TEST_NEW_WINDOW: Open Keyman Developer. Use Window|New Window to open a new instance of Keyman Developer, which should open with no project open.
  • TEST_WINDOW_MENU: Open several instances of Keyman Developer and open projects in each instance. Verify that the windows shown in the Window menu match up with the open projects.

@mcdurdin mcdurdin requested a review from darcywong00 as a code owner December 6, 2023 04:46
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Dec 6, 2023
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Dec 6, 2023 •
edited
Loading

User Test Results

Test specification and instructions

  • ✅ TEST_NEW_WINDOW (PASSED): Tested with the attached PR build (Keyman 17.0.225-alpha-test-10154) on Windows 11 OS (VM) and here is my observation: 1. 1. Opened an existing project in Keyman Developer. 2. Using the Window / New Window option, open another project window. 3. Tried to open different projects using the Window / New Window option. 4. I got an error message while trying to open a custom project. Tried to reproduce this with another project. But it seems to be a random one. (notes)
  • ✅ TEST_WINDOW_MENU (PASSED): Tested with the attached PR build (Keyman 17.0.225-alpha-test-10154) on Windows 11 OS (VM) and here is my observation: 1. Opened several projects of Keyman Developer in separate windows. 2. Randomly select a project window and open the Window / New window option. Verified that the Window menu matched up with the opened project. (notes)

@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S27 milestone Dec 6, 2023
@mcdurdin mcdurdin linked an issue Dec 6, 2023 that may be closed by this pull request
feat(developer): multi-process model would benefit from a Window menu #10149
Closed
@mcdurdin mcdurdin changed the title feat(developer): Add Window menu feat(developer): Add Window menu 🦕 Dec 6, 2023
@mcdurdin mcdurdin mentioned this pull request Dec 6, 2023
Closed
69 tasks
@darcywong00
Copy link
Copy Markdown
Contributor

darcywong00 commented Dec 6, 2023

Some UX question to catch me up.

  1. Is the "Window" listing replacing the previous "File" and "Project" menu items in Developer?
  2. It feels like a verb/action is missing in the screenshot (Would the user know what selecting a .kpj does?)
  3. Is there a menu to navigate for closing one of these open Keyman Developer processes?

@mcdurdin
Copy link
Copy Markdown
Member Author

mcdurdin commented Dec 6, 2023

  • Is the "Window" listing replacing the previous "File" and "Project" menu items in Developer?

No, this is about currently open windows. So it doesn't change those menus at all.

  • It feels like a verb/action is missing in the screenshot (Would the user know what selecting a .kpj does?)

This is a fairly standard pattern, e.g. what does selecting the File/Recent/file.kmn do?

  • Is there a menu to navigate for closing one of these open Keyman Developer processes?

Yes, File|Exit, or the [X] titlebar button.

@darcywong00
Copy link
Copy Markdown
Contributor

darcywong00 commented Dec 6, 2023

Gotcha. And what does selecting "1 (No project loaded)" do? I saw it's the title when not IsProjectOpen - So is it a placeholder when process 1 is available?

@mcdurdin
Copy link
Copy Markdown
Member Author

mcdurdin commented Dec 6, 2023

And what does selecting "1 (No project loaded)" do? I saw it's the title when not IsProjectOpen - So is it a placeholder when process 1 is available?

Process 1 is a Keyman Developer process that is running but does not currently have an active project -- so no files open.

@bharanidharanj
Copy link
Copy Markdown

bharanidharanj commented Dec 6, 2023

Test Results

  • TEST_NEW_WINDOW (PASSED): Tested with the attached PR build (Keyman 17.0.225-alpha-test-10154) on Windows 11 OS (VM) and here is my observation: 1. 1. Opened an existing project in Keyman Developer. 2. Using the Window / New Window option, open another project window. 3. Tried to open different projects using the Window / New Window option. 4. I got an error message while trying to open a custom project. Tried to reproduce this with another project. But it seems to be a random one.

..Open a new instance using the Window / New Window option

..error message while trying to open a custom project (random)

@bharanidharanj
Copy link
Copy Markdown

bharanidharanj commented Dec 6, 2023

Test Results

  • TEST_WINDOW_MENU (PASSED): Tested with the attached PR build (Keyman 17.0.225-alpha-test-10154) on Windows 11 OS (VM) and here is my observation: 1. Opened several projects of Keyman Developer in separate windows. 2. Randomly select a project window and open the Window / New window option. Verified that the Window menu matched up with the opened project.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Dec 6, 2023
@mcdurdin
Copy link
Copy Markdown
Member Author

mcdurdin commented Dec 7, 2023

  • I got an error message while trying to open a custom project. Tried to reproduce this with another project. But it seems to be a random one.

It looks like you clicked the 'Upgrade Project' button? If so, this is by design and working correctly -- the project cannot be upgraded to 17.0 format because there are several .kmn files listed in it which are in the wrong folder.

@mcdurdin mcdurdin modified the milestones: A17S27, A17S28 Dec 8, 2023
darcywong00
darcywong00 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from fix/developer/10144-10145-10146-10148 to master December 12, 2023 21:45
@mcdurdin mcdurdin merged commit 0b05013 into master Dec 12, 2023
@mcdurdin mcdurdin deleted the feat/developer/10149-window-menu branch December 12, 2023 21:45
@keyman-server
Copy link
Copy Markdown
Collaborator

keyman-server commented Dec 13, 2023

Changes in this pull request will be available for download in Keyman version 17.0.229-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darcywong00 darcywong00 darcywong00 approved these changes

Assignees

No one assigned

Labels

developer/ide/ developer/ feat has-user-test

Projects

None yet

Milestone

A17S28

Development

Successfully merging this pull request may close these issues.

feat(developer): multi-process model would benefit from a Window menu

4 participants

@mcdurdin @darcywong00 @bharanidharanj @keyman-server