change(web): prep for enhanced flick-resets - alters the contact-path evaluation signature 🐵#10152
Merged
jahorton merged 2 commits intofeature-gesturesfrom Dec 13, 2023
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
jahorton
commented
Dec 6, 2023
| itemPriority: 1, | ||
| pathModel: { | ||
| evaluate: (path, baseStats) => { | ||
| evaluate: (path, dummy, dummy2, baseStats) => { |
Contributor
Author
There was a problem hiding this comment.
This evaluate function as a whole will be changing in a near-followup, so I was lazy with the dummy-var naming here.
4fa268d to
ef247ba
Compare
ermshiperete
approved these changes
Dec 11, 2023
Base automatically changed from
feat/web/gesture-path-memory-optimization
to
feature-gestures
December 12, 2023 00:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip