fix(developer): prevent opening .kpj in multiple processes 🦕#10137
Merged
fix(developer): prevent opening .kpj in multiple processes 🦕#10137
Conversation
Fixes #10003. Multiple small fixes required here: * Add .kpj as an editable file type * Ensure that when OpenFile returns nil (which it always will for a .kpj), that we don't crash * Ensure that projects open in a new process rather than replacing the current project session Adds a TODO for New Project -- this should be opened in a new process if we already have a project open in the current process. Will push this into a separate PR.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
This was referenced Dec 5, 2023
Base automatically changed from
feat/developer/multi-process-file-loading
to
master
December 5, 2023 23:50
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.225-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10003.
Multiple small fixes required here:
Adds a TODO for New Project -- this should be opened in a new process if we already have a project open in the current process. Will push this into a separate PR (see #10138).
@keymanapp-test-bot skip