Skip to content

fix(common): publish @keymanapp/developer-utils as npm module#10118

Merged
mcdurdin merged 3 commits intomasterfrom
fix/common/10111-developer-utils-npm-module
Dec 2, 2023
Merged

fix(common): publish @keymanapp/developer-utils as npm module#10118
mcdurdin merged 3 commits intomasterfrom
fix/common/10111-developer-utils-npm-module

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin commented Dec 1, 2023

@mcdurdin mcdurdin requested a review from darcywong00 as a code owner December 1, 2023 07:06
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Dec 1, 2023

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

Copy link
Copy Markdown
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, does developer-utils have docs around it that it's more of an implementation detail?

@mcdurdin
Copy link
Copy Markdown
Member Author

mcdurdin commented Dec 1, 2023

developer-utils have docs around it that it's more of an implementation detail?

Added a basic README.md.

@github-actions github-actions bot added common/ and removed common/ labels Dec 1, 2023
@github-actions github-actions bot added common/ and removed common/ labels Dec 1, 2023
@mcdurdin mcdurdin merged commit 9cc8b40 into master Dec 2, 2023
@mcdurdin mcdurdin deleted the fix/common/10111-developer-utils-npm-module branch December 2, 2023 04:28
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.222-alpha

@srl295
Copy link
Copy Markdown
Member

srl295 commented Dec 3, 2023

Didn't get to test but lgtm.

Want a CI test for it?

@mcdurdin
Copy link
Copy Markdown
Member Author

mcdurdin commented Dec 4, 2023

Want a CI test for it?

That's a bit of infrastructure work I think? How would you foresee that working?

@srl295
Copy link
Copy Markdown
Member

srl295 commented Dec 5, 2023

Want a CI test for it?

That's a bit of infrastructure work I think? How would you foresee that working?

I'd think the Dockerfile as a GitHub action in #10111 (comment) could be run whenever a new release https://github.com/keymanapp/keyman/tags is created, and simply attempt an npm install and run against that tag.

@mcdurdin
Copy link
Copy Markdown
Member Author

mcdurdin commented Dec 5, 2023

OK, we don't have Docker on most of our build agents at present, so there's a chunk of work to set this up -- don't want to dive into adding extra infrastructure without consideration. Not that this isn't a good idea, but... even adding the GHA for Linux has been multiple weeks of effort to get it stable.

Do you want to open it as a separate issue?

@srl295
Copy link
Copy Markdown
Member

srl295 commented Dec 5, 2023

i'll prototype on my own GHA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(developer): kmc 17.0.220-alpha crashes with error on start

3 participants