fix(web): test-keyboard patchup 🐵#10104
Merged
jahorton merged 4 commits intofeature-gesturesfrom Dec 8, 2023
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
approved these changes
Nov 30, 2023
web/src/test/manual/web/keyboards/ye_old_ten_key/ye_old_ten_key.js
Outdated
Show resolved
Hide resolved
ermshiperete
approved these changes
Dec 5, 2023
Base automatically changed from
feat/web/multitap-preview-hints
to
feature-gestures
December 8, 2023 16:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exists to fix a newly detected issue with a few of the gesture-test keyboards: in particular, that I forgot to highlight the shift key when on a shift layer for the multitap keyboards.
@keymanapp-test-bot skip