fix(web): app/webview did not clear deadkeys on context-reset#10039
Merged
fix(web): app/webview did not clear deadkeys on context-reset#10039
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
jahorton
commented
Nov 22, 2023
| this.contextManager.configure({ | ||
| resetContext: (target) => { | ||
| // Could reset the target's deadkeys here, but it's really more of a 'core' task. | ||
| // So we delegate that to keyboard-processor. |
Contributor
Author
There was a problem hiding this comment.
Considering that deadkeys are very much managed internally by desktop-Core, this seemed like the right decision... given that we plan to integrate desktop-Core in the future.
mcdurdin
approved these changes
Nov 22, 2023
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.216-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered during user-test development for #9973: our mobile app context-reset commands were not erasing deadkeys from the context. This likely was a missed "loose thread" that arose from ES-modularization work.
@keymanapp-test-bot skip
User test TEST_APP_10_KEY_DIACRITICS from #9973 covers this sufficiently; this change has been 🍒-picked for
masterfrom thatfeature-gesturesPR.