Skip to content

feat: u_xxxx_yyyy key identifiers#487

Merged
mcdurdin merged 3 commits intomasterfrom
feat/u_xxxx_yyyy
Nov 16, 2021
Merged

feat: u_xxxx_yyyy key identifiers#487
mcdurdin merged 3 commits intomasterfrom
feat/u_xxxx_yyyy

Conversation

@mcdurdin
Copy link
Copy Markdown
Member

Relates to keymanapp/keyman#2858.

Documentation for this feature change, allowing for U_1234_1235_1236[_...] key identifiers.

Relates to keymanapp/keyman#2858.

Documentation for this feature change, allowing for
`U_1234_1235_1236[_...]` key identifiers.
@mcdurdin mcdurdin added this to the A15S17 milestone Nov 11, 2021
@mcdurdin mcdurdin added the feat label Nov 11, 2021
@mcdurdin mcdurdin marked this pull request as draft November 11, 2021 02:11
@mcdurdin mcdurdin marked this pull request as ready for review November 11, 2021 02:31
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@rc-swag rc-swag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion

Co-authored-by: rc-swag <58423624+rc-swag@users.noreply.github.com>
@mcdurdin mcdurdin modified the milestones: A15S17, A15S18 Nov 14, 2021
@mcdurdin mcdurdin merged commit b561420 into master Nov 16, 2021
@mcdurdin mcdurdin deleted the feat/u_xxxx_yyyy branch November 16, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants