Skip to content

feat: add Option to Control keys#291

Closed
scotch83 wants to merge 1 commit intokeycastr:mainfrom
scotch83:fix/add-option-key-to-control-keys
Closed

feat: add Option to Control keys#291
scotch83 wants to merge 1 commit intokeycastr:mainfrom
scotch83:fix/add-option-key-to-control-keys

Conversation

@scotch83
Copy link

@scotch83 scotch83 commented Feb 5, 2024

This development adds the option key to the keys to be displayed when only control keys are selected in the preferences

@akitchen
Copy link
Member

akitchen commented Feb 5, 2024

Thank you for opening a PR, but the option to include the option key in the set of control keys needs to also be a user-facing option for the default visualizer, as option is not a control key, it is a modifier key.

@akitchen
Copy link
Member

akitchen commented Feb 5, 2024

A more ideal solution to this feature request is to have a progression from control keys only, to all modified keys (i.e. shift and option), then all keystrokes. This warrants some thought in the preferences UI as well.

@scotch83
Copy link
Author

Maybe we can add an option in the preferences or change the label to "only modifier keys"?

@akitchen
Copy link
Member

akitchen commented Jun 9, 2024

I decided to implement this as an option for the default visualizer, it is in the v0.9.17 release

@akitchen akitchen closed this Jun 9, 2024
@scotch83 scotch83 deleted the fix/add-option-key-to-control-keys branch June 9, 2024 13:22
@scotch83
Copy link
Author

scotch83 commented Jun 9, 2024

I decided to implement this as an option for the default visualizer, it is in the v0.9.17 release

Thank you @akitchen 🙏 and sorry for not following up much on this but it's not really a language I am good at so I did not want to waste anyone's time with further non relevant solutions.

Thank you for implementing this in the new release thou ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants