ci: use crazymax/xgo:1.18.1 docker image as base#17
Merged
Conversation
Otherwise the `$HOME` variable is not set which results in: ``` + make test go test -v ./... failed to initialize build cache at /.cache/go-build: mkdir /.cache: permission denied Makefile:31: recipe for target 'test' failed ``` Signed-off-by: Jakub Sokołowski <jakub@status.im>
The old `xgo` image does not work: ``` ../../../../pkg/mod/github.com/ethereum/go-ethereum@v1.10.26/common/test_utils.go:27:18: undefined: os.ReadFile note: module requires Go 1.17 Makefile:31: recipe for target 'test' failed ``` Signed-off-by: Jakub Sokołowski <jakub@status.im>
fbb38dc to
c9a28e9
Compare
bitgamma
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old
xgoimage does not work:Appears to work: https://ci.status.im/job/status-keycard/job/keycard-cli/153/