Skip to content

fix warnings#9

Merged
kevinohashi merged 3 commits intokevinohashi:masterfrom
tomjn:tomjn_fix_warnings
Oct 1, 2021
Merged

fix warnings#9
kevinohashi merged 3 commits intokevinohashi:masterfrom
tomjn:tomjn_fix_warnings

Conversation

@tomjn
Copy link
Contributor

@tomjn tomjn commented Dec 31, 2018

This adds:

  • some escaping
  • removes the PHP4 action hooks, we don't need to do array( &$this... we can just do array( $this
  • Fixes a PHP warning on the tools page for an undefined offset
  • Fixes the way that the scripts and styles are enqueued so that they're only enqueued on the correct hook
  • Use the parameters from the hook used in the previous fix to conditionally load the styles rather than looking at the $_SERVER global

@tomjn
Copy link
Contributor Author

tomjn commented Dec 31, 2018

@kevinohashi can I get an approval/merge?

@kevinohashi kevinohashi merged commit 342a8c1 into kevinohashi:master Oct 1, 2021
@kevinohashi
Copy link
Owner

Sorry this took so long, I probably meant to test and check it years ago and then forgot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants