Added leading zero for "9" minutes and seconds#9
Merged
kevinkhill merged 1 commit intokevinkhill:masterfrom Sep 9, 2017
Merged
Added leading zero for "9" minutes and seconds#9kevinkhill merged 1 commit intokevinkhill:masterfrom
kevinkhill merged 1 commit intokevinkhill:masterfrom
Conversation
Owner
|
Thank you! I didn't even realize I was missing some edge cases. I also don't know what is wrong with Travis, so thank you for the screenshots. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, Kevin!
I have fixed a bug in "formatted" method with missed leading zero for values "9" of minutes and seconds where hours or minutes exists accordingly.
Before that fix PHPUnit throwed failure on values "1:09" and "1:09:00", now it passes tests normally.