drop support for Python 3.6 with pyupgrade and other pre-commit tools#68
Merged
drop support for Python 3.6 with pyupgrade and other pre-commit tools#68
Conversation
Collaborator
Author
|
this also drops support for all EOL python versions (which happens to be all previously supported python versions) |
Collaborator
Author
|
might be worth a v2 for this change |
hugovk
reviewed
Feb 25, 2022
Contributor
hugovk
left a comment
There was a problem hiding this comment.
Looks good!
I suggest mentioning the EOL drop prominently in the PR title, for extra visibility.
d69352e to
c7e13cf
Compare
c7e13cf to
e76d250
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.