Merged
Conversation
Collaborator
|
Awesome work @Vitaliy-1 ! I've processed a couple thousand PDF and looked at a few of them. Tables look often very good. The main issue I think, as you noted in your examples, is when the table notes are added in the last line of the table. Possibly we could introduce an additional label in the table model to label those table notes explicitly to get them removed from the table content. What do you think? Thanks a lot for the contribution! |
kermitt2
approved these changes
Feb 29, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Algorithms for table parsing. Inspired by: http://ieg.ifs.tuwien.ac.at/projects/pdf2table/yildiz_iicai05.pdf
Particularly, I've implemented the first algorithm from there and the idea in general. I suppose it's called the line-based approach. It works much better than tabula, as a minimum on my test instance.
related to:
#514
#340
Examples: https://vitaliy-1.github.io/tablesExample/